Skip to content

Conversation

@ilhan007
Copy link
Contributor

@ilhan007 ilhan007 commented Nov 25, 2025

Improve vertical alignment of inline web comps by forcing same vertical-align (vertical-align: middle in this case brought by FormComponents.css).

Before:

Screenshot 2025-11-25 at 16 36 36

After
Screenshot 2025-11-25 at 16 33 57

Changes

  • RatingIndicator, Switch, CheckBox, RadioButton, DatePicker, Slider now use vertical-align: middle as the rest of the form components
  • StepInput was the only input element with width: 100% falling on next line, all the rest can stay side by side
  • Text use to behave as a block element, falling on next line, due to its display: -webkit-box; => changed to display: -webkit-inline-box; to behave properly
  • Slider focus placement is fixed. e.g equal space around the handles

before
Screenshot 2025-12-02 at 11 03 05
after
Screenshot 2025-12-02 at 15 42 33

@ui5-webcomponents-bot
Copy link
Collaborator

ui5-webcomponents-bot commented Nov 25, 2025

🧹 Preview deployment cleaned up: https://pr-12718--ui5-webcomponents.netlify.app

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 25, 2025 14:43 Inactive
@ilhan007 ilhan007 requested a review from MapTo0 November 26, 2025 12:07
@dimovpetar
Copy link
Member

Text change looks good to me.

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 28, 2025 09:12 Inactive
@ilhan007 ilhan007 requested a review from kgogov December 1, 2025 12:24
@kgogov
Copy link
Contributor

kgogov commented Dec 1, 2025

CheckBox looks fine :)

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 3, 2025 07:50 Inactive
@ilhan007 ilhan007 requested a review from nnaydenow December 3, 2025 09:10
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 3, 2025 09:15 Inactive
@tsanislavgatev
Copy link
Contributor

Components on my end look good.

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 3, 2025 11:29 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 17, 2025 14:41 Inactive
@ilhan007 ilhan007 changed the title fix(ui5-*): improve vertical alignment of inline web comps fix(ui5-*): improve vertical alignment of inline web comps Dec 17, 2025
@ilhan007 ilhan007 merged commit dda0591 into main Dec 17, 2025
21 of 22 checks passed
@ilhan007 ilhan007 deleted the fix-vertical-alignment-of-inline-components branch December 17, 2025 14:50
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 17, 2025 14:50 Inactive
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.18.0-rc.1 🎉

The release is available on v2.18.0-rc.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants