feat(ui5-search): enhance accessibility support #12717
Merged
+42
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-12717--ui5-webcomponents.netlify.app |
remove tabindex -1 from delete button to restore keyboard navigation
…into search-acc
ivoplashkov
requested changes
Dec 5, 2025
Contributor
|
aria-label is applied on ui5-button, however it's not propageted properly to the native button, could you please check if there is something incorrect on our side ? |
fix button accessibility attributes
…into search-acc
remove aria-label to prevent double announcements by screen readers
ivoplashkov
approved these changes
Dec 17, 2025
Collaborator
|
🎉 This PR is included in version v2.18.0-rc.1 🎉 The release is available on v2.18.0-rc.1 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
aria-controlsandaria-autocompleteattributes to theui5-search-fieldJIRA: BGSOFUIRILA-4136