style: fix rustfmt comment alignment in test functions#6
Open
melvincarvalho wants to merge 3 commits into
Open
style: fix rustfmt comment alignment in test functions#6melvincarvalho wants to merge 3 commits into
melvincarvalho wants to merge 3 commits into
Conversation
Align comments with extra spacing to satisfy rustfmt check.
The function requires 8 parameters due to configuration options. Adding the allow attribute to suppress the lint warning in CI.
- Use From instead of TryFrom with Infallible error type - Fix sliced_string_as_bytes: use as_bytes() before slicing - Remove unused Infallible import
melvincarvalho
force-pushed
the
fix/rustfmt-alignment
branch
from
cd957f1 to
76858ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo fmt --checkin CIProblem
The previous PR #5 introduced lines that don't match the project's rustfmt style:
Should be:
Test plan
cargo testpasses