Merged
Conversation
EdwardJXLi
force-pushed
the
edward/radio-board-integration
branch
from
bfc8618 to
d2bdcd6
Compare
JonnoGG
approved these changes
Feb 13, 2026
| if (dst_buf) { | ||
| net_buf_unref(dst_buf); | ||
| } | ||
| counter++; |
Collaborator
There was a problem hiding this comment.
do we want to increment counter on fails? could make the ground station think its missing some messages when its not.
I dont think this ever will fail in this manner to be fair, but idk
| net_buf_unref(src_buf); | ||
| net_buf_unref(dst_buf); | ||
|
|
||
| counter++; |
Collaborator
There was a problem hiding this comment.
same here. should counter increment on failed sends? just an architectural decision
|
|
||
| tx_buf[0] = SPI_CMD_RADIO_TX; | ||
| /* bytes 1-4 are dummy (already zeroed) */ | ||
| // memcpy(&tx_buf[SPI_HEADER_SIZE], cobs_data, cobs_len); |
JonnoGG
force-pushed
the
edward/radio-board-integration
branch
from
d2bdcd6 to
3cd5cd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.