fix: update CreateLinkButton to be able to toggle popover visibility #2316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix an issue with the
CreateLinkButtoncomponent which cannot be closed. This problem was hidden with non static formatting toolbar as the component was unmount with the toolbar. But with static toolbar, once the link popover was opened, it was not possible to close it.#2313
Rationale
Fix a bug that cause lot of feedbacks/support in the application I'm developing.
Changes
Make the
CreateLinkButtonPopover fully controlled.Impact
Testing
Tested during development through the static formatting toolbar example.
Screenshots/Video
CleanShot.2025-12-23.at.18.23.06.mp4
Checklist
Additional Notes