Skip to content

Conversation

@jbpenrath
Copy link

Summary

Fix an issue with the CreateLinkButton component which cannot be closed. This problem was hidden with non static formatting toolbar as the component was unmount with the toolbar. But with static toolbar, once the link popover was opened, it was not possible to close it.

#2313

Rationale

Fix a bug that cause lot of feedbacks/support in the application I'm developing.

Changes

Make the CreateLinkButton Popover fully controlled.

Impact

Testing

Tested during development through the static formatting toolbar example.

Screenshots/Video

CleanShot.2025-12-23.at.18.23.06.mp4

Checklist

  • Code follows the project's coding standards.
  • Unit tests covering the new feature have been added. (I don't see any test suite for the react package)
  • All existing tests pass.
  • [N/A] The documentation has been updated to reflect the new feature

Additional Notes

@vercel
Copy link

vercel bot commented Dec 23, 2025

@jbpenrath is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

@jbpenrath jbpenrath force-pushed the fix/create-link-button-open-state branch from f919041 to de8db60 Compare December 23, 2025 17:31
@jbpenrath jbpenrath changed the title fix: update CreateLinkButton to toggle popover visibility and handle … fix: update CreateLinkButton to be able to toggle popover visibility Dec 23, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 23, 2025

Open in StackBlitz

@blocknote/ariakit

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/ariakit@2316

@blocknote/code-block

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/code-block@2316

@blocknote/core

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/core@2316

@blocknote/mantine

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/mantine@2316

@blocknote/react

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/react@2316

@blocknote/server-util

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/server-util@2316

@blocknote/shadcn

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/shadcn@2316

@blocknote/xl-ai

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-ai@2316

@blocknote/xl-docx-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-docx-exporter@2316

@blocknote/xl-email-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-email-exporter@2316

@blocknote/xl-multi-column

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-multi-column@2316

@blocknote/xl-odt-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-odt-exporter@2316

@blocknote/xl-pdf-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-pdf-exporter@2316

commit: de8db60

@vercel
Copy link

vercel bot commented Dec 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
blocknote Ready Ready Preview Dec 23, 2025 8:22pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants