-
-
Notifications
You must be signed in to change notification settings - Fork 662
feat: Versioning & suggesting changes example #2312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matthewlipski
wants to merge
10
commits into
main
Choose a base branch
from
versioning-demo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,786
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an example which combines all available collaboration features, including comments, versioning, and suggesting changes.
There's a sidebar that can show the comments or saved version snapshots. The snapshots can be previewed, renamed and reverted. Reverting a snapshot also creates a backup snapshot just before the revert, and one just after.
If the sidebar is displaying comments, then clicking a comment in the editor will scroll to and select the comment in the sidebar (works vice-versa when clicking a comment in the sidebar). Otherwise, the floating comment viewer will be used.
Aside from being able to change users for editing/commenting rights, you can also change the editing mode from regular editing to suggesting changes. Suggested additions and removals are highlighted in green and red, and can be either individually applied/reverted or all at once.
Rationale
This is a nice showcase of everything collaboration related that BlockNote has to offer, and is useful for testing those features.
Changes
Impact
N/A
Testing
Did a decent amount of manual testing but there might still be some rough edges I haven't found, especially using the 3 different features together.
Screenshots/Video
Checklist
Additional Notes
TODOs:
@handlewithcare/prosemirror-suggest-changespackage, which is ID based. This bug should be fixed after moving to the new Yjs implementation, but should be double checked.withSuggestChangesis applied todispatchin theBlockNoteEditorconstructor. It should really be in the suggestions extensionmountmethod, but I couldn't get this to work.LinkToolbarControllercomponent. This is because hovering a text node in the block, the mouse event target will point to the parent.bn-inline-contentrather than the text node itself. Therefore,posAtDOMresolves to a position at the start of the block's inline content, which is also the start of the link. UsingposAtCoordsand using the mouse coords fixes this.re-think-snapshotbranch for more thoughts