fix: Create link button force show selection bug #2217
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When you click the link creation button, it autofocuses the URL input which blurs the editor and would normally hide the selection. However,
showSelectionfrom theShowSelectionExtensionis called at the same time to prevent this.However, this is never cleaned up, the the editor selection is still forced to be shown. This PR fixes this issue by calling
showSelection(false)when the create link button component gets unmounted.Rationale
This issue causes bad UX and should be fixed.
Changes
N/A
Impact
N/A
Testing
Added case to UI testing Notion doc.
Screenshots/Video
Checklist
Additional Notes