fix(justfile): skip real dirs in _common-setup link loop#45
Merged
Conversation
`_common-setup` linked every entry under `home/` and `config/` with `ln -sf`, which fails when the destination is a populated real directory (e.g. `~/.config/doom`, `~/.config/emacs`) — `unlink()` cannot remove a directory, so the recipe aborted. Guard each iteration: if the destination already exists as a real directory (not a symlink), print `skip <name> (real dir)` and continue. Use `-snf` so dangling symlink-to-dir cases are also replaced cleanly. The `for f in "$root/home/".*` loop now uses a `case` filter for `.`/`..` rather than the previous compound test that interacts poorly with `set -e`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_common-setuplinked every entry underhome/andconfig/withln -sf, which fails when the destination is a populated real directory (e.g.~/.config/doom,~/.config/emacs) —unlink()cannot remove a directory, so the recipe aborted.Guard each iteration: if the destination already exists as a real directory (not a symlink), print
skip <name> (real dir)and continue. Use-snfso dangling symlink-to-dir cases are also replaced cleanly. Thefor f in "$root/home/".*loop now uses acasefilter for./..rather than the previous compound test that interacts poorly withset -e.