feat(sdk): add convenience search methods to NfdClient#10
Merged
Conversation
Add methods to simplify common NFD search operations: - `resolveAddress`: Find NFD for a specific wallet address - `searchByOwner`: Search for NFDs owned by a wallet address - `searchForSale`: Search for NFDs currently for sale
Restores the behavior of resetting the `signer` after `mint` operations complete, which was inadvertently removed during the addition of new search methods. This ensures the `mint` method continues to work as expected and passes tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds convenience methods to the
NfdClientclass to simplify common NFD search operations. These methods make it easier for integrators to perform common queries without having to construct complex search parameters.Details
resolveAddressmethod to find the NFD associated with a specific wallet addresssearchByOwnermethod to search for all NFDs owned by a specific wallet addresssearchForSalemethod to search for all NFDs that are currently for sale@remarkstags explaining the default limitsAddressobject parameters consistently