🎨 Palette: Improve Language Switcher UX/Accessibility#16
🎨 Palette: Improve Language Switcher UX/Accessibility#16
Conversation
Changes: - Replaced non-semantic `<span>` tags with `onClick` handlers with accessible `<button>` elements. - Added `focus-visible:outline` utility classes to support clear visual indicators during keyboard navigation. - Added descriptive `aria-label`s to explicitly state the language being switched to. - Wrapped the decorative slash (`/`) separator with `aria-hidden="true"` to prevent it from being read by screen readers. - Kept changes strictly under 50 lines and used existing CSS classes. Co-authored-by: Twinber <5513621+Twinber@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Converted non-semantic spans into interactive buttons with proper focus states and ARIA attributes in the Language Switcher component.
🎯 Why: Non-semantic spans do not support keyboard navigation (tabbing, Enter/Space activation) or provide adequate context for screen readers.
📸 Before/After: Focus states added, ARIA labels added, decorative elements hidden.
♿ Accessibility: Ensures full keyboard navigability and provides clear descriptive labels for assistive technologies.
PR created automatically by Jules for task 18085149910551968658 started by @Twinber