Skip to content

🎨 Palette: Improve LanguageSwitcher accessibility #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Twinber wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🎨 Palette: Improve LanguageSwitcher accessibility #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-05-24 - Semantic Buttons for Language Switcher
**Learning:** The app's `LanguageSwitcher` used `<span>` tags with `onClick` handlers for interactive elements. This is an accessibility anti-pattern as it lacks keyboard focusability and screen reader semantics.
**Action:** Always verify custom interactive toggles and switchers use semantic `<button>` tags with appropriate `aria-label`s and `focus-visible` styles rather than non-interactive tags.
Loading