Closed
Conversation
test the rehash now Signed-off-by: Adam Hockley <adamh1989@hotmail.com>
Fixed the order to match cache_user_motd() - stat() must be called before free_cachefile() to avoid potential race conditions or crashes. The stat() call should happen first to get file metadata, then free and reload the cache.
- Fix use-after-free crash in free_cachefile (removed invalid rb_free on embedded data) - Fix race condition in send_user_motd/send_oper_motd (use safe iterators, capture pointers locally) - Fix unsafe pointer swap in cache_user_motd/rehash_omotd (load new cache first, then swap) - Add proper error handling in cache_file (check malloc failures, file read errors, emptyline NULL check) - Add error reporting to cache_user_motd (show errors in chat when /rehash motd fails) - Preserve old MOTD if new one fails to load - Fix same issues in rehash_rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.