Fixing FPE when an item is not initialised. #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Spotted first with 3.1.4 version but thought it was due to missing data but then occurred again (but randomly and rarely) with 3.2.0 as well, basically 216 items while possibly 218. Do not know if the approach would be to not load the game or this solution or making sure all data is present. |
Collaborator
|
To clarify, 3.2.0 increased the number of items by 1, as well as adding a new entry to items.txt. Likely crash is on a line like (appearance % items[type].variations) where variations is uninitialised and could be 0. Solution can also be just to properly initialise some item properties to non-0 |
Contributor
Author
|
Yes exactly a fpe is division by zero. |
…tialise data at best
devnexen
force-pushed
the
item_fp_exception
branch
from
d1ea8bc to
bf5ec76
Compare
Contributor
Author
|
Tried your suggestion, realising building under Mac is ... tricky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.