Skip to content

SyncPRSummary: make a separate bot comment for #27

Open
shravanngoswamii wants to merge 4 commits intomainfrom
sg-SyncPRSummary
Open

SyncPRSummary: make a separate bot comment for #27
shravanngoswamii wants to merge 4 commits intomainfrom
sg-SyncPRSummary

Conversation

@shravanngoswamii
Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Member

@penelopeysm penelopeysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this will probably create a single comment, but it will come after the PR first comment, and it will also come after all the individual bot spam. I wonder if you could also somehow use the GitHub API to hide all the individual bot comments (since with the consolidated version, they wouldn't be necessary anymore)? We can't delete them ofc, because the individual benchmark etc. workflows need to have them, that's why I'm thinking of hiding.

@shravanngoswamii
Copy link
Copy Markdown
Member Author

I wonder if you could also somehow use the GitHub API to hide all the individual bot comments

tbh, I would prefer having all the bot comments in single comment, maybe adding separate markers for each might help (Code Coverage, docs, benchmarks comments). I am not sure how Code Coverage setup works, I will have to look into that.

@penelopeysm
Copy link
Copy Markdown
Member

Right, I guess the issue is that we're using someone else's workflow for the review comment stuff, and we might have to hand-roll our own. I wouldn't mind that too, it would be more elegant -- it's mostly a question of whether it's worth the time to implement it, but that's a decision you can make.

@shravanngoswamii
Copy link
Copy Markdown
Member Author

shravanngoswamii commented Mar 23, 2026

Right, I guess the issue is that we're using someone else's workflow for the review comment stuff

I think we are using reviewdog for review comments and peterevans actions for other commenting purpose. And we also have some thollander action for commenting -- I don't exactly remember where are we using this one but I am sure I did add that somewhere. (edit: docs, main website and DoodleBUGS)

If we can put together something of our own, it would be great to have! But I don't think it's worth the time because even if we combine all bot comments into one, review comments should still be kept separated (obvious reasons of them getting deleted once resolved) and reviewdog is well maintained for this purpose too.

#28)

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants