Skip to content

Micro-optimise append_optic; fix serialisation for JSON@1.5.0#154

Merged
penelopeysm merged 6 commits intomainfrom
py/optims
Apr 4, 2026
Merged

Micro-optimise append_optic; fix serialisation for JSON@1.5.0#154
penelopeysm merged 6 commits intomainfrom
py/optims

Conversation

@penelopeysm
Copy link
Copy Markdown
Member

@penelopeysm penelopeysm commented Apr 4, 2026

shortcircuit the recursion in a simple case

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2026

AbstractPPL.jl documentation for PR #154 is available at:
https://TuringLang.github.io/AbstractPPL.jl/previews/PR154/

@penelopeysm
Copy link
Copy Markdown
Member Author

penelopeysm commented Apr 4, 2026

honestly this is not even a micro-optimisation, it's more like a nano-optimisation

the CI failure is bizarre though, i can't reproduce it offline Reproduced, the culprit is upgrading JSON.jl from 1.4.0 to 1.5.0

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.51%. Comparing base (97d0f21) to head (0211966).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   84.49%   84.51%   +0.02%     
==========================================
  Files          10       10              
  Lines         561      562       +1     
==========================================
+ Hits          474      475       +1     
  Misses         87       87              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@penelopeysm penelopeysm changed the title Micro-optimise append_optic Micro-optimise append_optic; fix serialisation for JSON@1.5.0 Apr 4, 2026
@penelopeysm penelopeysm merged commit 76dc6df into main Apr 4, 2026
9 checks passed
@penelopeysm penelopeysm deleted the py/optims branch April 4, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant