horse_drop.json file fix (actually works this time)#33
Open
TBlazeWarriorT wants to merge 3 commits intoTschipp:1.19from
Open
horse_drop.json file fix (actually works this time)#33TBlazeWarriorT wants to merge 3 commits intoTschipp:1.19from
TBlazeWarriorT wants to merge 3 commits intoTschipp:1.19from
Conversation
horse_drop.json requires a type referencing the mod's defined loot modifier, and "this" should be lowercase to avoid issues
Added an actual check if the disableHorseDrops setting is on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
horse_drop.json requires a type to work, without it it was not being parsed, not stopping horse drops, and causing a console error. All of this was fixed.
Despite this fix, Disable Horse Drops setting itself is still not implemented. "disableHorseDrops" is defined on the config but is never used, shame on you lol
Without the JSON fix, ALL horses may still drop loot
With the JSON fix, ALL non-personal horses may still drop loot
The other Commit changes HorseDropModifier.java to actually check for the Disable Horse Drops setting and make the mod (hopefully) fully work as intended.
Note that I couldn't find the mod's 1.3.0.1 version on this repo that seems to be based on 1.3.0.0