Fix TryQuiet#3017: ESC causes unwanted closing of the join/create#3154
Open
BlooBamboo wants to merge 2 commits intoTryQuiet:developfrom
Open
Fix TryQuiet#3017: ESC causes unwanted closing of the join/create#3154BlooBamboo wants to merge 2 commits intoTryQuiet:developfrom
BlooBamboo wants to merge 2 commits intoTryQuiet:developfrom
Conversation
community view Added guarded close handling, so Escape and backdrop clicks are ignored when isCloseDisabled is true. Updated modal wiring to use the guarded handler and pass disableEscapeKeyDown. Added regression test 'does not close on Escape when close is disabled'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
community view Added guarded close handling, so Escape and backdrop clicks are ignored when isCloseDisabled is true. Updated modal wiring to use the guarded handler and pass disableEscapeKeyDown. Added regression test 'does not close on Escape when close is disabled'.
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: