Add better-sqlite3 to dev dependencies and CI#367
Open
kevinansfield wants to merge 3 commits intomainfrom
Open
Add better-sqlite3 to dev dependencies and CI#367kevinansfield wants to merge 3 commits intomainfrom
kevinansfield wants to merge 3 commits intomainfrom
Conversation
Member
kevinansfield
commented
Dec 2, 2025
kevinansfield
commented
- Add better-sqlite3 v12.5.0 as a dev dependency
- Create test config for better-sqlite3 environment
- Add better-sqlite3 to the CI testing matrix alongside sqlite3 and mysql8
- Add better-sqlite3 v12.5.0 as a dev dependency - Create test config for better-sqlite3 environment - Add better-sqlite3 to the CI testing matrix alongside sqlite3 and mysql8
better-sqlite3 requires Node 20.x or later, so exclude it from the Node 18.12.1 test matrix.
This allows yarn install to succeed on Node 18 where better-sqlite3 is not supported, similar to how sqlite3 is handled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.