Allowed more "ref" lines in commit messages#28261
Open
EvanHahn wants to merge 1 commit into
Open
Conversation
no ref This change should have no user impact. It just quiets a development-only warning. Before this change, our pre-commit hook showed a warning unless your commit's third line started with "ref", "fixes", or "closes". Now it supports a wide array of options. These are lifted from some our internal document, "How to write commit messages".
Contributor
WalkthroughThis PR updates the commit-msg validation hook to accept a broader set of issue-link keywords on the third line of commit messages. The validation regex is expanded to recognize 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no ref
This change should have no user impact. It just quiets a development-only warning.
Before this change, our pre-commit hook showed a warning unless your commit's third line started with "ref", "fixes", or "closes".
Now it supports a wide array of options. These are lifted from some our internal document, "How to write commit messages".