Skip to content

Fixed release workflow running on forks#28259

Open
kevinansfield wants to merge 1 commit into
TryGhost:mainfrom
kevinansfield:codex/release-workflow-upstream-only
Open

Fixed release workflow running on forks#28259
kevinansfield wants to merge 1 commit into
TryGhost:mainfrom
kevinansfield:codex/release-workflow-upstream-only

Conversation

@kevinansfield
Copy link
Copy Markdown
Member

@kevinansfield kevinansfield commented May 29, 2026

Summary

  • restricted the scheduled release job to the canonical TryGhost/Ghost repository
  • prevents forked repositories from executing the Friday release workflow job

no issue

The scheduled release workflow should only execute in TryGhost/Ghost because forks do not own the release process or its required secrets.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4ecfae3c-d65c-420a-9584-1d41314f614d

📥 Commits

Reviewing files that changed from the base of the PR and between 9f1a6c6 and 6085163.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Walkthrough

This PR adds a repository check to the release workflow. A single line was added to the release job definition in .github/workflows/release.yml, introducing an if condition that restricts job execution to the primary TryGhost/Ghost repository. This prevents the release pipeline from running in forked repositories while keeping the release script and job steps unchanged.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fixed release workflow running on forks' directly and clearly describes the main change: restricting the release workflow to only run in the canonical repository, not forks.
Description check ✅ Passed The description explains the core purpose of the PR: restricting the scheduled release job to TryGhost/Ghost and preventing forks from executing it, which aligns with the actual changes made.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@kevinansfield kevinansfield requested a review from rob-ghost May 29, 2026 16:59
@kevinansfield kevinansfield marked this pull request as ready for review May 29, 2026 17:00
@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.64%. Comparing base (9f1a6c6) to head (6085163).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #28259   +/-   ##
=======================================
  Coverage   73.63%   73.64%           
=======================================
  Files        1536     1536           
  Lines      130816   130816           
  Branches    15657    15657           
=======================================
+ Hits        96329    96336    +7     
- Misses      33498    33517   +19     
+ Partials      989      963   -26     
Flag Coverage Δ
admin-tests 54.21% <ø> (+0.02%) ⬆️
e2e-tests 73.64% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant