Skip to content

🐛 Fixed missing hidden comment bodies for Admins when loading comment permalinks #28195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinansfield wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛 Fixed missing hidden comment bodies for Admins when loading comment permalinks #28195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/comments-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@tryghost/comments-ui",
"version": "1.5.4",
"version": "1.5.5",
"license": "MIT",
"repository": "https://github.com/TryGhost/Ghost",
"author": "Ghost Foundation",
Expand Down
80 changes: 58 additions & 22 deletions apps/comments-ui/src/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ type AppProps = {
pageUrl: string;
};

type Pagination = NonNullable<EditableAppContext['pagination']>;
type CommentsRequestApi = {
browse: ({page, postId, order}: {page: number; postId: string; order?: string}) => Promise<{comments: Comment[]; meta: {pagination: Pagination}}>;
};

const ALLOWED_MODERATORS = ['Owner', 'Administrator', 'Super Editor'];
const LIKES_ORDER = 'count__likes desc, created_at desc';
const NET_SCORE_ORDER = 'count__net_score desc, created_at desc';
Expand Down Expand Up @@ -148,11 +153,45 @@ const App: React.FC<AppProps> = ({scriptTag, initialCommentId, pageUrl}) => {

if (admin) {
// this is a bit of a hack, but we need to fetch the comments fully populated if the user is an admin
const adminComments = await adminApi.browse({page: 1, postId: options.postId, order: state.order, memberUuid: state.member?.uuid});
const memberUuid = state.member?.uuid;
const adminComments = await adminApi.browse({page: 1, postId: options.postId, order: state.order, memberUuid});
let adminPermalinkState: Partial<EditableAppContext> | null = null;

if (initialCommentId) {
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Render auth frame for empty hidden-comment permalinks

This admin permalink recovery only runs after AuthFrame calls initAdminAuth, but the frame is still rendered only when state.comments.length > 0. For a permalink to a hidden comment on a post with no public comments, the member API returns an empty list and showMissingCommentNotice, so the auth frame is never mounted and this new adminApi.read path never executes; an authenticated admin still sees the missing-comment notice instead of the hidden comment.

Useful? React with 👍 / 👎.

try {
const targetResponse = await adminApi.read({commentId: initialCommentId, memberUuid});
const targetComment = targetResponse.comments?.[0];
if (targetComment) {
const result = await loadScrollTarget(
initialCommentId,
targetComment,
adminComments.comments,
adminComments.meta.pagination,
state.order,
{
browse: ({page, postId, order}) => adminApi.browse({page, postId, order, memberUuid})
}
);

if (result.found) {
adminPermalinkState = {
comments: result.comments,
pagination: result.pagination,
commentIdToScrollTo: initialCommentId,
commentIdFromHash: initialCommentId,
showMissingCommentNotice: false
};
}
}
} catch {
// Keep the public API permalink result when the admin API can't load this target.
}
}

setState((currentState) => {
// Don't overwrite comments when initSetup loaded extra data
// for permalink scrolling (multiple pages or expanded replies)
if ((currentState.pagination && currentState.pagination.page > 1) || initialCommentId) {
if ((currentState.pagination && currentState.pagination.page > 1 && !initialCommentId) || (initialCommentId && !adminPermalinkState)) {
return {
adminApi,
admin,
Expand All @@ -163,9 +202,12 @@ const App: React.FC<AppProps> = ({scriptTag, initialCommentId, pageUrl}) => {
adminApi,
admin,
isAdmin: true,
comments: adminComments.comments,
pagination: adminComments.meta.pagination,
capabilities: adminComments.meta?.capabilities ?? currentState.capabilities
comments: adminPermalinkState?.comments ?? adminComments.comments,
pagination: adminPermalinkState?.pagination ?? adminComments.meta.pagination,
capabilities: adminComments.meta?.capabilities ?? currentState.capabilities,
commentIdToScrollTo: adminPermalinkState?.commentIdToScrollTo ?? currentState.commentIdToScrollTo,
commentIdFromHash: adminPermalinkState?.commentIdFromHash ?? currentState.commentIdFromHash,
showMissingCommentNotice: adminPermalinkState?.showMissingCommentNotice ?? currentState.showMissingCommentNotice
};
});
}
Expand Down Expand Up @@ -222,18 +264,20 @@ const App: React.FC<AppProps> = ({scriptTag, initialCommentId, pageUrl}) => {
targetId: string,
parentId: string | undefined,
initialComments: Comment[],
initialPagination: {page: number; pages: number},
order = state.order
initialPagination: Pagination,
order = state.order,
requestApi?: CommentsRequestApi
): Promise<{comments: Comment[]; pagination: typeof initialPagination}> => {
let comments = initialComments;
let pagination = initialPagination;
const commentsApi = requestApi ?? {browse: api.comments.browse};

while (!isCommentLoaded(comments, targetId) && pagination.page < pagination.pages) {
if (parentId && comments.some(c => c.id === parentId)) {
break;
}

const nextPage = await api.comments.browse({
const nextPage = await commentsApi.browse({
page: pagination.page + 1,
postId: options.postId,
order
Expand All @@ -246,29 +290,21 @@ const App: React.FC<AppProps> = ({scriptTag, initialCommentId, pageUrl}) => {
};

/**
* Load additional comment pages and/or replies until the scroll
* target is found. After paginating to the parent comment, if the
* target reply isn't in the inline replies (partial API response),
* fetch all replies from the server.
* Load additional comment pages until the scroll target is found.
*/
const loadScrollTarget = async (
targetId: string,
targetComment: Comment,
initialComments: Comment[],
initialPagination: {page: number; pages: number},
order = state.order
initialPagination: Pagination,
order = state.order,
requestApi?: CommentsRequestApi
): Promise<{comments: Comment[]; pagination: typeof initialPagination; found: boolean}> => {
const parentId = targetComment.parent_id;

const {comments: paginatedComments, pagination} = await paginateToComment(targetId, parentId, initialComments, initialPagination, order);
let comments = paginatedComments;

if (parentId && !isCommentLoaded(comments, targetId)) {
const {comments: allReplies} = await api.comments.replies({commentId: parentId, limit: 'all'});
comments = comments.map(c => (c.id === parentId ? {...c, replies: allReplies} : c));
}
const {comments: paginatedComments, pagination} = await paginateToComment(targetId, parentId, initialComments, initialPagination, order, requestApi);

return {comments, pagination, found: isCommentLoaded(comments, targetId)};
return {comments: paginatedComments, pagination, found: isCommentLoaded(paginatedComments, targetId)};
};

/** Initialize comments setup once in viewport, fetch data and setup state */
Expand Down
3 changes: 1 addition & 2 deletions apps/comments-ui/test/e2e/editor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ test.describe('Editor', async () => {

// Check comment
expect(mockedApi.comments).toHaveLength(1);
expect(mockedApi.comments[0].html).toBe('<blockquote><p>This is a quote</p><p>This is a new line</p></blockquote><p>This is a new paragraph<br></p>');
expect(mockedApi.comments[0].html).toBe('<blockquote><p>This is a quote</p><p>This is a new line</p></blockquote><p>This is a new paragraph</p>');
});

test('Can paste an URL to create a link', async ({page}) => {
Expand Down Expand Up @@ -349,4 +349,3 @@ test.describe('Editor', async () => {
});
});
});

Loading
Loading