🐛 Fixed broken view-in-browser link for email-only posts#28192
Open
vershwal wants to merge 1 commit into
Open
Conversation
ref INC-290
- forPost's preview-URL override gated on `status !== 'published'`
AND `url.match(/\/404\//)`. The second guard worked because the
eager UrlService only indexed published resources, so any sent or
draft post returned /404/ and reliably triggered the override.
- Under `config.lazyRouting`, the lazy service has no implicit
status filter — the default unfiltered `/:slug/` collection
matches sent posts and returns `/{slug}/`. The /404/ guard
silently flipped to false, the override never fired, and emails
went out with the slug URL (which 404s in the browser).
- Gating on status alone works under both eager and lazy services
and restores the intended behaviour for the lazyRouting path. No behaviour change for
everyone else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref INC-290
status !== 'published'ANDurl.match(/\/404\//). The second guard worked because the eager UrlService only indexed published resources, so any sent or draft post returned /404/ and reliably triggered the override.config.lazyRouting, the lazy service has no implicit status filter — the default unfiltered/:slug/collection matches sent posts and returns/{slug}/. The /404/ guard silently flipped to false, the override never fired, and emails went out with the slug URL (which 404s in the browser).