✨ Added Klipy as a GIF provider alongside Tenor#28109
Merged
Merged
Conversation
Contributor
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis PR introduces Klipy configuration support across the Ghost platform. The change extends the Config type with an optional 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
11 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28109 +/- ##
==========================================
+ Coverage 73.62% 73.70% +0.07%
==========================================
Files 1536 1535 -1
Lines 130863 130745 -118
Branches 15654 15641 -13
==========================================
+ Hits 96348 96361 +13
+ Misses 33527 33395 -132
- Partials 988 989 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kevinansfield
approved these changes
Jun 1, 2026
Member
kevinansfield
left a comment
kevinansfield
left a comment
There was a problem hiding this comment.
All looks good 👌 If not squash-merging everything, I'd at least squash the Klipy config key and e2e test update together so there's an atomic commit to revert if needed. Otherwise good to merge 🙌
ref https://linear.app/ghost/project/replace-tenor-with-klipy-for-gif-cards-c48db5d2a3d5/overview - Google is shutting down the Tenor API on 2026-06-30, so the editor GIF card needs a replacement provider - exposes a `klipy` config block (apiKey, contentFilter) through public-config and the config serializer, mirroring the existing `tenor` block - forwards `klipy` into the card config of the Ember post editor and the admin-x welcome-email editor so Koenig can resolve Klipy when a key is set - Tenor stays in place as a fallback; this adds Klipy alongside it
ref https://linear.app/ghost/project/replace-tenor-with-klipy-for-gif-cards-c48db5d2a3d5/overview - the `tenor` Ember service was the GIF client for the old pre-Lexical editor - the current editor (@tryghost/koenig-lexical) ships its own GIF client, so the service has had zero injection sites since the Lexical migration - dead code removal, no behaviour change
ref https://linear.app/ghost/project/replace-tenor-with-klipy-for-gif-cards-c48db5d2a3d5/overview - adding klipy to public-config and the output serializer changed the /config/ API response - the e2e-api config snapshot still only had the tenor block, so config.test.js would have failed CI - regenerated and verified by running test/e2e-api/admin/config.test.js (3 passing)
- the klipy GIF provider migration requires the corresponding Koenig editor releases that add klipy support - bumped @tryghost/koenig-lexical and the kg-* / html-to-mobiledoc packages to their .2 patch releases - added the same-day releases to minimumReleaseAgeExclude so the 1-day cooldown does not block install
renatoworks
force-pushed
the
tenor-klipy-migration
branch
from
89d0168 to
44a450b
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/admin-x-settings/package.json`:
- Line 65: The PR/AI summary is missing the pnpm catalog migration note for the
lucide-react dependency: update the PR summary/description to state that in
apps/admin-x-settings/package.json the lucide-react version was changed from
pinned "0.577.0" to the pnpm "catalog:" strategy; mention this
dependency-management change alongside the Klipy/GIF-related work so reviewers
see it (edit the PR description or AI-generated summary text to include
"lucide-react: 0.577.0 → catalog:" and a short note that this is a pnpm catalog
migration).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9b90d7fa-bf91-4955-b23e-12694f34b44a
📒 Files selected for processing (5)
apps/admin-x-framework/src/api/config.tsapps/admin-x-framework/src/test/responses/config.jsonapps/admin-x-settings/package.jsonapps/admin-x-settings/src/components/settings/membership/member-emails/member-email-editor.tsxapps/admin/package.json
✅ Files skipped from review due to trivial changes (3)
- apps/admin/package.json
- apps/admin-x-framework/src/test/responses/config.json
- apps/admin-x-framework/src/api/config.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/admin-x-settings/src/components/settings/membership/member-emails/member-email-editor.tsx
Contributor
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/admin-x-settings/package.json`:
- Line 65: The PR/AI summary is missing the pnpm catalog migration note for the
lucide-react dependency: update the PR summary/description to state that in
apps/admin-x-settings/package.json the lucide-react version was changed from
pinned "0.577.0" to the pnpm "catalog:" strategy; mention this
dependency-management change alongside the Klipy/GIF-related work so reviewers
see it (edit the PR description or AI-generated summary text to include
"lucide-react: 0.577.0 → catalog:" and a short note that this is a pnpm catalog
migration).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9b90d7fa-bf91-4955-b23e-12694f34b44a
📒 Files selected for processing (5)
apps/admin-x-framework/src/api/config.tsapps/admin-x-framework/src/test/responses/config.jsonapps/admin-x-settings/package.jsonapps/admin-x-settings/src/components/settings/membership/member-emails/member-email-editor.tsxapps/admin/package.json
✅ Files skipped from review due to trivial changes (3)
- apps/admin/package.json
- apps/admin-x-framework/src/test/responses/config.json
- apps/admin-x-framework/src/api/config.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/admin-x-settings/src/components/settings/membership/member-emails/member-email-editor.tsx
🛑 Comments failed to post (1)
apps/admin-x-settings/package.json (1)
65-65:
⚠️ Potential issue | 🟡 Minor | ⚡ Quick win🧩 Analysis chain
🏁 Script executed:
#!/bin/bash # Check if lucide-react is used in GIF/Klipy related code echo "=== Searching for lucide-react usage in GIF or Klipy related contexts ===" rg -n "lucide-react" -A 3 -B 3 | rg -i "(gif|klipy|tenor)" -C 5 echo "" echo "=== Checking git history for this change ===" git log --all --full-history --oneline -- "apps/admin-x-settings/package.json" | head -10Repository: TryGhost/Ghost
Length of output: 847
🏁 Script executed:
#!/bin/bash set -euo pipefail FILE="apps/admin-x-settings/package.json" echo "=== Current lucide-react entry (around line 65) ===" nl -ba "$FILE" | sed -n '55,75p' | sed -n '/lucide-react/,+3p' echo echo "=== Search for pinned lucide-react versions in the current file ===" rg -n '"lucide-react"\s*:\s*"' "$FILE" || true rg -n 'lucide-react.*0\.577\.0' "$FILE" || true echo echo "=== Value in the commit that moved lucide-react to the pnpm catalog ===" # commit from earlier output: 46904c97 "Moved `lucide-react` to default pnpm catalog (`#28152`)" git show "46904c97:$(echo "$FILE")" --no-color 2>/dev/null | rg -n '"lucide-react"\s*:' || true echo echo "=== Check whether any GIF/Klipy-related changes touch lucide-react ===" # quick contextual check: look for lucide-react changes in the last ~30 commits touching that file git log -n 30 --oneline -- "$FILE" --no-color | head -50Repository: TryGhost/Ghost
Length of output: 171
🏁 Script executed:
#!/bin/bash set -euo pipefail FILE="apps/admin-x-settings/package.json" echo "=== Current lucide-react entry in $FILE (near lucide-react) ===" rg -n '"lucide-react"\s*:' "$FILE" || true sed -n '55,75p' "$FILE" echo echo "=== Does the current file contain pinned lucide-react 0.577.0? ===" rg -n 'lucide-react.*0\.577\.0' "$FILE" || true rg -n '0\.577\.0' "$FILE" || true echo echo "=== lucide-react value in commit 46904c97 ===" git show "46904c97:$FILE" --no-color | rg -n '"lucide-react"\s*:' || true echo echo "=== List commits touching lucide-react in this file (latest 40) ===" git log -n 40 --oneline -- "$FILE" --no-color | head -40Repository: TryGhost/Ghost
Length of output: 1118
🏁 Script executed:
#!/bin/bash set -euo pipefail FILE="apps/admin-x-settings/package.json" echo "=== lucide-react value around line in working tree ===" rg -n '"lucide-react"\s*:' "$FILE" echo echo "=== lucide-react value at commit 46904c97 ===" git show "46904c97:$FILE" --no-color | rg -n '"lucide-react"\s*:' echo echo "=== lucide-react value at parent of 46904c97 (to check 0.577.0) ===" PARENT="$(git rev-parse '46904c97^')" echo "Parent sha: $PARENT" git show "${PARENT}:$FILE" --no-color | rg -n '"lucide-react"\s*:' echo echo "=== Is 0.577.0 present in parent commit's file? ===" git show "${PARENT}:$FILE" --no-color | rg -n '0\.577\.0' || true echo echo "=== Commits touching this file (lucide-react related changes should appear here) ===" git log -n 20 --oneline --no-color -- "$FILE" | head -20 echo echo "=== lucide-react imports/usage in repo (limited), to see if tied to Klipy/GIF ===" rg -n "from ['\"]lucide-react['\"]|['\"]lucide-react['\"]" -- 'apps' | head -50 echo echo "=== lucide-react usage in files containing klipy/gif/tenor keywords ===" rg -n --files-with-matches "lucide-react" apps | while read -r f; do if rg -qi "(gif|klipy|tenor)" "$f"; then echo "MATCH: $f" fi done | head -50Repository: TryGhost/Ghost
Length of output: 5998
Fix PR/AI summary to include
lucide-reactdependency strategy change.
apps/admin-x-settings/package.jsonupdateslucide-reactfrom pinned0.577.0tocatalog:(pnpm catalog migration). The summary should mention this dependency-management change (it’s adjacent to the Klipy/GIF-related work in the file history).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/admin-x-settings/package.json` at line 65, The PR/AI summary is missing the pnpm catalog migration note for the lucide-react dependency: update the PR summary/description to state that in apps/admin-x-settings/package.json the lucide-react version was changed from pinned "0.577.0" to the pnpm "catalog:" strategy; mention this dependency-management change alongside the Klipy/GIF-related work so reviewers see it (edit the PR description or AI-generated summary text to include "lucide-react: 0.577.0 → catalog:" and a short note that this is a pnpm catalog migration).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the problem you are solving
This PR adds Ghost-side support for Klipy as a GIF provider in the editor's GIF card, alongside the existing Tenor provider. Google is shutting down the Tenor API on 2026-06-30, so a replacement is needed.
The actual Klipy provider implementation lives in
@tryghost/koenig-lexical(paired PR: TryGhost/Koenig#1932). This PR adds the Ghost-side plumbing: aklipyconfig key, forwarded through both editors to the Koenig card config, plus removal of a dead pre-Lexical Ember service.No breaking changes. Without a Klipy key configured, behaviour is identical to today: the editor's GIF card continues to use Tenor exactly as before. The new
klipyconfig block defaults tonull, and anykoenig-lexicalversion that does not know the field simply ignores it. The Klipy path only becomes active for a deployment that (a) gets the newerkoenig-lexicalversion via a separate dependency bump, and (b) configures a Klipy key.Each PR in this pair is independently safe to merge: they are backward-compatible in every direction. The dependency bump that connects them is a separate small follow-up (Renovate's auto-PR, or a tiny manual PR), not part of this PR.
Changelog for devs
klipyconfig block (apiKey,contentFilter) toghost/core/core/shared/config/defaults.json, the public-config service, and the config output serializer, mirroring the existingtenorblockklipyfield to theConfigtype inadmin-x-frameworkand the test response fixtureklipyinto the editor card config inghost/admin/app/components/koenig-lexical-editor.js(Ember post editor) andapps/admin-x-settings/src/components/settings/membership/member-emails/member-email-editor.tsx(admin-x welcome-email editor)ghost/admin/app/services/tenor.js(the pre-Lexical editor's GIF client, zero injection sites; the current Lexical editor ships its own GIF client)klipyblockChangelog for customers
klipy.apiKeyconfig key (becomes active once the paired Koenig dependency bump lands)Notes
tenorconfig key, the Tenor-specific public-config and serializer entries, and the Tenor-specific tests. Until then, Tenor stays as the fallback so deployments without a Klipy key continue to work unchanged.pnpm.overrideslink:to the Koenig branch; that override is not included in this PR.media.tenor.comwill continue serving existing asset URLs to third-party requests after the API shutdown, so existing embedded GIFs in published Ghost content remain safe; no Ghost(Pro) CDN re-host is required. The action Google asks of us is precisely what this migration delivers: replace the search/embed API by June 30.Technical debt
klipyconfig block mirrors thetenorshape. If we add further GIF providers, consolidating into a singlegifProviderblock would reduce duplication; not done here to keep this change minimal and 1:1 with the existing pattern.PR Scope (mark all that apply)
Checklist before requesting a review (mark all that apply)