Skip to content

Removed all instances of memberWelcomeEmailTestInbox configuration#26553

Merged
cmraible merged 2 commits intomainfrom
chris-ny-1086-remove-the-memberwelcomeemailtestinbox-configuration-from
Feb 25, 2026
Merged

Removed all instances of memberWelcomeEmailTestInbox configuration#26553
cmraible merged 2 commits intomainfrom
chris-ny-1086-remove-the-memberwelcomeemailtestinbox-configuration-from

Conversation

@cmraible
Copy link
Collaborator

@cmraible cmraible commented Feb 24, 2026

closes https://linear.app/ghost/issue/NY-1086/remove-the-memberwelcomeemailtestinbox-configuration-from-ghost

We no longer use the memberWelcomeEmailTestInbox configuration parameter anywhere in Ghost, but it still exists in defaults.json and a few other configuration fixtures, as well as our e2e tests. This removes any and all references to this obsolete configuration parameter from the codebase.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7213788 and 9d28fba.

📒 Files selected for processing (5)
  • e2e/helpers/playwright/fixture.ts
  • ghost/core/core/shared/config/defaults.json
  • ghost/core/core/shared/config/env/config.testing-mysql.json
  • ghost/core/core/shared/config/env/config.testing.json
  • href.md
💤 Files with no reviewable changes (1)
  • e2e/helpers/playwright/fixture.ts
🚧 Files skipped from review as they are similar to previous changes (2)
  • ghost/core/core/shared/config/env/config.testing.json
  • ghost/core/core/shared/config/env/config.testing-mysql.json

Walkthrough

This pull request removes the memberWelcomeEmailTestInbox configuration property across the codebase. The property is deleted from the GhostConfig interface in e2e/helpers/playwright/fixture.ts and from the configuration files ghost/core/core/shared/config/defaults.json, ghost/core/core/shared/config/env/config.testing.json, and ghost/core/core/shared/config/env/config.testing-mysql.json. No other keys or values are modified.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title clearly and concisely summarizes the main change: removal of all instances of the memberWelcomeEmailTestInbox configuration parameter.
Description check ✅ Passed The pull request description is directly related to the changeset, explaining why memberWelcomeEmailTestInbox is being removed and which files are affected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chris-ny-1086-remove-the-memberwelcomeemailtestinbox-configuration-from

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cmraible
Copy link
Collaborator Author

@CodeRabbit review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 24, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cmraible cmraible changed the title Removed all instances of memberWelcomeEmailTestInbox configuration Removed all instances of memberWelcomeEmailTestInbox configuration Feb 24, 2026
@cmraible cmraible force-pushed the chris-ny-1086-remove-the-memberwelcomeemailtestinbox-configuration-from branch from 7213788 to 9d28fba Compare February 24, 2026 20:54
@cmraible cmraible marked this pull request as ready for review February 24, 2026 23:03
@cmraible cmraible requested a review from 9larsons as a code owner February 24, 2026 23:03
@cmraible cmraible requested a review from troyciesco February 24, 2026 23:58
@cmraible cmraible merged commit afb011e into main Feb 25, 2026
33 checks passed
@cmraible cmraible deleted the chris-ny-1086-remove-the-memberwelcomeemailtestinbox-configuration-from branch February 25, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants