🐛 Fixed invisible comments filter dropdown in Safari#26484
🐛 Fixed invisible comments filter dropdown in Safari#26484kevinansfield wants to merge 1 commit intomainfrom
Conversation
fixes https://linear.app/ghost/issue/BER-3153/ Safari resolved the popover's offset parent differently from Chrome, causing the translateX to be off by the sidebar width (300px). Wrapping PopoverContent in a Portal renders it to document.body, matching the pattern already used by SelectContent and HoverCardContent in shade.
WalkthroughThe Popover component in 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
weylandswart
left a comment
There was a problem hiding this comment.
Sorry for taking so long with the review. Tested and all looks good to me!
fixes https://linear.app/ghost/issue/BER-3153/
PopoverContentinPopoverPrimitive.Portalto fix filter popover positioning in SafaritranslateXto be off by exactly the sidebar width (300px), pushing it off-screenSelectContentandHoverCardContentin shade, and the standard shadcn/ui popover implementation