.github/workflows: Migrate workflows to Blacksmith runners#26471
.github/workflows: Migrate workflows to Blacksmith runners#26471blacksmith-sh[bot] wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26471 +/- ##
==========================================
- Coverage 73.10% 73.08% -0.02%
==========================================
Files 1539 1539
Lines 120439 120439
Branches 14496 14494 -2
==========================================
- Hits 88041 88019 -22
- Misses 31393 31413 +20
- Partials 1005 1007 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
| - name: Setup Blacksmith Builder | ||
| uses: useblacksmith/setup-docker-builder@v1 |
There was a problem hiding this comment.
Unused cache-key variable and output remain
Low Severity
The CACHE_KEY variable is computed and set as a step output but never used anywhere in the workflow. After migrating to Blacksmith's automatic caching, the cache-from and cache-to parameters that referenced steps.strategy.outputs.cache-key were removed, making this variable and output dead code. The computation on line 994, the output on line 999, and the debug echo on line 1005 should all be removed.
Additional Locations (1)
jonatansberg
force-pushed
the
blacksmith-migration-341e413
branch
3 times, most recently
from
92d9b0b to
a09ef9b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| run: yarn test:e2e:all --retries=2 | ||
|
|
||
| - name: Upload test results artifacts | ||
| - name: Upload Playwright report |
There was a problem hiding this comment.
E2E blob reporter makes uploaded artifact empty
Medium Severity
e2e/playwright.config.mjs uses the 'blob' reporter in CI (unchanged by this PR), which outputs files to e2e/blob-report/ — not e2e/playwright-report/. The deleted job_merge_e2e_reports job previously merged those blob files into an HTML report in playwright-report/. Now that the merge job is removed, e2e/playwright-report/ is never populated in CI, so the uploaded artifact will be empty and the npx playwright show-report command instructed to users will not work.
jonatansberg
force-pushed
the
blacksmith-migration-341e413
branch
3 times, most recently
from
08a61bd to
b86b8f9
Compare
jonatansberg
force-pushed
the
blacksmith-migration-341e413
branch
from
b86b8f9 to
7b5d238
Compare
To whomever may be reviewing this PR,
Blacksmith is the fastest way to run your GitHub Actions.
What does this PR change?
This PR has been automatically generated by a team member in your GitHub organization using Blacksmith's Migration Wizard, or MigWiz for short. This PR changes the following:
runs-on: blacksmith-4vcpu-ubuntu-2204). Learn more about the different instances available to choose from.FAQ
Note
Medium Risk
Touches core CI infrastructure (runner selection and Docker build/push path), which can impact build reliability/performance, but does not change application runtime logic.
Overview
Moves the
CIGitHub Actions workflow fromubuntu-latest(andubuntu-latest-4-cores) to Blacksmith runner labels across all jobs, with larger Blacksmith instances for browser/E2E, acceptance, and Docker build workloads.Switches Docker image builds in
job_docker_buildand the E2E Tinybird CLI image build fromdocker/setup-buildx-action+docker/build-push-actionto Blacksmith’ssetup-docker-builderandbuild-push-action, and drops the explicit registry-basedcache-from/cache-toconfiguration.Written by Cursor Bugbot for commit 6b91d82. This will update automatically on new commits. Configure here.