Skip to content

Comments

Unified E2E env manager#26223

Closed
jonatansberg wants to merge 6 commits intomainfrom
ber-3077-unified-env-manager
Closed

Unified E2E env manager#26223
jonatansberg wants to merge 6 commits intomainfrom
ber-3077-unified-env-manager

Conversation

@jonatansberg
Copy link
Member

Got some code for us? Awesome 🎊!

Please take a minute to explain the change you're making:

  • Why are you making it?
  • What does it do?
  • Why is this something Ghost users or developers need?

Please check your PR against these items:

  • I've read and followed the Contributor Guide
  • I've explained my change
  • I've written an automated test to prove my change works

We appreciate your contribution! 🙏

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ber-3077-unified-env-manager

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 21674607256 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.09%. Comparing base (9b3d4ef) to head (f4d86fa).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26223      +/-   ##
==========================================
- Coverage   73.10%   73.09%   -0.01%     
==========================================
  Files        1539     1539              
  Lines      120439   120439              
  Branches    14496    14493       -3     
==========================================
- Hits        88041    88029      -12     
- Misses      31393    31404      +11     
- Partials     1005     1006       +1     
Flag Coverage Δ
admin-tests 53.80% <ø> (-0.02%) ⬇️
e2e-tests 73.09% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jonatansberg jonatansberg force-pushed the ber-3077-unified-env-manager branch 2 times, most recently from 53fc27c to d780a39 Compare February 5, 2026 13:38
@jonatansberg jonatansberg force-pushed the ber-3077-unified-env-manager branch from d780a39 to 673ab58 Compare February 18, 2026 14:37
@github-actions
Copy link
Contributor

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 22144088945 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"

refs https://linear.app/ghost/issue/BER-3077/improve-e2e-testing-integration

This will let us reuse the containers for mysql, redis, etc across
different compose configurations.
refs https://linear.app/ghost/issue/BER-3077/improve-e2e-testing-integration

This expects front end assets to have been built externally using the existing
NX setup. This way we can better leverage the cache in CI.
refs https://linear.app/ghost/issue/BER-3077/improve-e2e-testing-integration

Removed the old environment manager and extended what used to be the dev
environment manager to support usage within CI and with prebuilt docker images.
@jonatansberg jonatansberg force-pushed the ber-3077-unified-env-manager branch from 673ab58 to 1abf7a5 Compare February 19, 2026 08:35
@github-actions
Copy link
Contributor

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 22174398376 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"

@github-actions
Copy link
Contributor

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 22175014781 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"

@jonatansberg jonatansberg force-pushed the ber-3077-unified-env-manager branch from 569f982 to f4d86fa Compare February 19, 2026 09:11
@github-actions
Copy link
Contributor

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 22175487759 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"

no ref 

Added member-attribution readiness wait into public POM navigation and portal 
helpers to fix attribution assertions.
@jonatansberg
Copy link
Member Author

Closing in favour of #26539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant