test: fix help docs test by adding _import_module to fake kernel

[zza-830]

Problem

test_run_help_prints_docstring_for_known_command was failing across all open PRs because the fake kernel in the test lacked a _import_module method. When run_help tried to import the settings module, it hit an AttributeError that was silently caught, falling through to "No detailed help available".

Fix

Added a working _fake_import_module function to the test's SimpleNamespace fake kernel that uses importlib.import_module() to resolve the module path. This allows run_help to successfully load the module, read the docstring, and print it.

Verification

tests/test_help_docs.py::test_run_help_prints_docstring_for_known_command PASSED

Fixes the CI failure affecting PRs #50, #51, #53, #54.

Summary by CodeRabbit

• Tests

  • Updated the help-docs test to use the real settings module and its docstring for assertions, with a small adjustment to internal test stubbing/formatting.

• Documentation

  • Removed an in-code explanatory comment in the command-normalization area (no change to the underlying behavior).

[AkshajSinghal]

Great find!
But I'd request you to implement these changes:

1. Add error handling for malformed quoting in _os_passthrough.
2. Add a Windows path test case to ensure spaces/backslashes are handled correctly.
3. Update the README to accurately describe the new sanitization process.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c028d558-8d4c-4b5a-9c62-7bff4185616b

📥 Commits

Reviewing files that changed from the base of the PR and between 2bbe1f2 and 823b3b4.

📒 Files selected for processing (1)

• tests/test_help_docs.py

---

📝 Walkthrough

Walkthrough

Test kernel setup refactored to use real module imports via a _fake_import_module helper instead of stubs, validating help output against the actual run_settings docstring. Multi-line explanatory comment removed from CLI normalization path; no logic changes.

Changes

Test kernel refactoring and CLI cleanup

Layer / File(s)	Summary
Test kernel setup refactoring with real module imports tests/test_help_docs.py	Added importlib import and reworked fake_kernel setup with a _fake_import_module helper that loads the real module from registry path mapping. Wired this helper into fake_kernel._import_module to validate help text against the actual run_settings docstring instead of a stubbed function.
CLI comment removal trushell/cli.py	Removed a multi-line explanatory comment immediately before the lowercase command/argument normalization in app_with_lower; runtime behavior unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• TruFoundation/TruShell#58: Both PRs touch tests/test_help_docs.py to validate help output driven by the kernel's registry (one adds registry/module-import-based tests; the other refines the test to use the real run_settings docstring/module import plumbing).

Poem

🐰 A comment fades from the CLI's way,
Real modules now light the test's day,
No stubby fakes, just truth laid bare,
Help docs verified with utmost care. 🥕

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding _import_module to the fake kernel to fix a failing test in test_help_docs.py.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

⚔️ Resolve merge conflicts

• Resolve merge conflict in branch fix/help-docs-test

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[zza-830]

Thanks for the review! This PR is specifically a test fix — it adds _import_module to the fake kernel in test_help_docs.py so the help docstring test passes. The _os_passthrough error handling and Windows path test you mentioned are outside the scope of this PR, but great ideas for follow-up work.

Merge conflict with upstream/main has been resolved. Ready for another look!

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/test_help_docs.py`:
- Line 3: Remove the dead helper and unused import: delete the unused function
_fake_import_module and its assignment to fake_kernel._import_module, and remove
the importlib import since it's only referenced by that dead function; keep the
working mock assignment (the lambda that returns fake_module) as the sole
_import_module replacement so tests still pass.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 70442d9b-75ad-4969-84f6-6989b2ef371f

📥 Commits

Reviewing files that changed from the base of the PR and between 7ab2e53 and 5050b4d.

📒 Files selected for processing (2)

• tests/test_help_docs.py
• trushell/cli.py

💤 Files with no reviewable changes (1)

• trushell/cli.py