Open
Conversation
Author
|
Update: I found a dark-mode issue that texts appear black when being clicked. |
Author
|
Both the icon rendering issue (Swift-ver. only) and the text color issue (both ObjC and Swift ver.) are solved. |
[SWIFT] layout() // Fix icon rendering issue.
Author
|
I concatenated recent commits since they are too much, including the removal of some useless comments I added previously in the Swift version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I rewrote this entire project in Swift. The Swift version is named as NSClassicAlert instead in order to avoid naming confliction issues.
In the project, the Swift version is provided as a framework. However, it is easy to reorganize it as a Swift package.
The default UI font and its size are changed to the default fonts used since macOS 10.11 El Capitan in lieu of specifically specifying the Helvetica Neue (which is Yosemite-specific).
There are only one issues left:
Note: There is no "releaseAll()" in the Swift version since Swift ARC automatically handles this.
If introducing
releaseAll(), the message texts immediately disappear after the alert panel loaded successfully.