chore(adr): record protobuf rpc over nats micro binding decision#471
chore(adr): record protobuf rpc over nats micro binding decision#471yordis wants to merge 1 commit into
Conversation
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryLow Risk Overview The decision ties The ADR index gains a link to the new record. ADR 0017 (decider commands) is referenced as a specialization of this binding. Reviewed by Cursor Bugbot for commit 571e4cc. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR adds a new Architecture Decision Record (ADR 0016) documenting how annotated Protocol Buffers services bind to NATS micro, covering service/endpoint mapping, subject derivation, error discrimination via headers, content-type negotiation, and lists it in the ADR index. ChangesADR Documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
trogon.nats.micro.v1alpha1annotations already ship in trogon-proto without an ADR defining what they mean on the wire.