Refresh firebase token when user is logged in#30
Merged
Conversation
navyaa31
requested changes
Mar 4, 2026
Collaborator
navyaa31
left a comment
There was a problem hiding this comment.
Thanks for addressing this so fast! I just left a few comments
| useEffect(() => { | ||
| const unsubscribe = auth.onIdTokenChanged(async (user) => { | ||
| if (user) { | ||
| const token = await user.getIdToken(); |
Collaborator
There was a problem hiding this comment.
Can we add error handling around this
Collaborator
There was a problem hiding this comment.
can we move this file into a folder called contexts?
| const unsubscribe = auth.onIdTokenChanged(async (user) => { | ||
| if (user) { | ||
| const token = await user.getIdToken(); | ||
| document.cookie = `firebaseAuthToken=${token}; path=/`; |
Collaborator
There was a problem hiding this comment.
Can we set security attributes on this?
https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Set-Cookie
navyaa31
approved these changes
Mar 10, 2026
Collaborator
navyaa31
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for addressing comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing