Tag Filtering Type Separation by YoChang410 · Pull Request #27 · TritonSE/Home-Start

YoChang410 · 2026-03-02T22:23:12Z

Changes

Changed Tags column on the table to Status, Event and Volunteer Type
Tag filter buttons show all tags of their type
Volunteer filtering now works with new Volunteer and Tag schema
Fixed misc. bugs with Tag fetching and Volunteer validation
Removed proxy route for tag backend

Testing

Tested with dummy data

How to test:
Run backend and frontend as normal. Use the team database, which has dummy data matching the new schemas.
Open http://localhost:3000/volunteers and apply any tags from the tab filter buttons.
Note: you may need to log out and log back in first. Then navigate to the volunteers page.

Behavior when multiple filters are applied at once: AND” relation across filter types, and “OR” relation within filter types. For example, if selected: Events “Charity Run” and “Holiday Drive”, and Status “returning”, it will return all volunteers that have “returning” AND (either charity run OR holiday drive)
'Clear All' button should remove all filters

Confirmation of Change

…ags, separated volunteer type and event tags

…ilters when filters are applied

…le formatting

navyaa31

I left a couple comments. One other thing is that "new" and "returning" are lower case rn but could you make them uppercase to match the other tags. Could you send screenshots to the designers and get their feedback as well?

navyaa31 · 2026-03-10T18:41:44Z

-                <span>Tags</span>
+                <span>Status</span>
+                <span>
+                  <img src="/sort-arrow.svg" alt="" className={styles.sortIcon} />


can we remove the sort arrows

navyaa31 · 2026-03-10T18:44:56Z

Could we have the frontend call the backend endpoints directly and remove this proxy route? you can refer to this PR where Michael removed proxies, and keep a look out for when its merged in

github-actions · 2026-04-03T19:07:40Z

Visit the preview URL for this PR (updated for commit 38467e1):

https://home-start-80e0a--pr27-feat-tag-filter-type-rkzo3osk.web.app

_{(expires Tue, 21 Apr 2026 18:33:58 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 2d310071333235bae3893f27fc89786faff3470f}

navyaa31

looks good! I just left comments about a couple minor changes

navyaa31 · 2026-04-03T19:02:26Z

 export const metadata: Metadata = {
-  title: "Home Start",
-  description: "Home Start dashboard",
+  title: "Create Next App",


Can we change this back to "Home Start" and the description to "Home Start dashboard"

navyaa31 · 2026-04-03T19:03:32Z

+        {hasSearch && (
+          <div className={styles.inputField}>
+            <span className={styles.ic_search}>
+              <img src="/Union.svg" alt="Union logo" className={styles.union} />


Can we use Image instead of img? I think if you just change it back to how we used Image before, it should be good

Also can you move everything in app/components to /components. Currently there are two components folders so we are moving everything in app/components to /components

CharlieSuarezRobles

Everything looks good to me. The only problem is that I get an error when I click on the volunteers button in the dashboard.

siwenshao · 2026-04-07T21:42:00Z

+        const [volunteerData, tagData] = await Promise.all([fetchVolunteers(), fetchTags()]);
+        setVolunteers(volunteerData);
+        setTags(tagData);
+        console.log("raw tag data", tagData);


I don't think we need this after we are done with debugging

siwenshao · 2026-04-07T21:44:22Z

  email: string;
  phoneNumber: string;
  tags: VolunteerTag[];
+  status: string;


maybe we can tighten status typing to "new" | "returning" instead of plain string

siwenshao

Navyaa covered most of the must-fix, I left a couple nit comments. Otherwise, the rest looks good to me!

…uttons for tag categories

CharlieSuarezRobles

Everything looks good to me and works fine on my side.

…ome-Start into feat/tag-filter-types merge.

navyaa31

looks good, thank you

YoChang410 added 3 commits February 18, 2026 21:09

Tags backend from other branch, rewrote tag filters to use database t…

7890809

…ags, separated volunteer type and event tags

separeted tags into respective colummns, added style change for tag f…

0941f0a

…ilters when filters are applied

minor changes, now functional with new tag backend

5e865b9

YoChang410 requested a review from navyaa31 as a code owner March 2, 2026 22:23

YoChang410 marked this pull request as draft March 3, 2026 20:09

YoChang410 added 4 commits March 4, 2026 15:46

merge main into this branch

6b5cfdb

misc fixes to Volunteer status field, Tag fetching, and Volunteer tab…

7c8822e

…le formatting

added status filtering

fcad4f3

rewrote multi-layer filter logic

9996aa0

YoChang410 marked this pull request as ready for review March 10, 2026 00:22

navyaa31 requested a review from CharlieSuarezRobles March 10, 2026 17:36

navyaa31 assigned njbizzle and unassigned njbizzle Mar 10, 2026

navyaa31 requested review from njbizzle and wmiq84 and removed request for CharlieSuarezRobles March 10, 2026 17:36

navyaa31 requested changes Mar 10, 2026

View reviewed changes

YoChang410 added 2 commits March 31, 2026 19:58

Made status tags capitalized, removed proxy API route for tags

8e8f3c9

merged in main

522da20

navyaa31 requested review from CharlieSuarezRobles, navyaa31 and siwenshao and removed request for njbizzle and wmiq84 April 2, 2026 23:29

fixed unused makeStatusValidator

659854f

navyaa31 requested changes Apr 3, 2026

View reviewed changes

CharlieSuarezRobles reviewed Apr 7, 2026

View reviewed changes

siwenshao reviewed Apr 7, 2026

View reviewed changes

YoChang410 and others added 3 commits April 9, 2026 15:34

moved components to src/components, other misc changes to volunteer page

9b00647

minor UI changes: rounded border for volunteer table, and Clear All b…

f5ef20f

…uttons for tag categories

solving 404 error

ca6dcb5

CharlieSuarezRobles approved these changes Apr 11, 2026

View reviewed changes

YoChang410 and others added 9 commits April 10, 2026 23:46

main merge

aaf1b6b

Merge branch 'feat/tag-filter-types' of https://github.com/TritonSE/H…

966917f

…ome-Start into feat/tag-filter-types merge.

readded deleted Sidebar component

30a5c7a

fixed some imports

ce9acf5

another import error with SuccessToast

6c58ff7

template issues

5d283b0

lint warning

d4f3eba

normalizeVolunteerStatus

81010b1

Merge branch 'main' into feat/tag-filter-types

34e0ab8

navyaa31 requested review from navyaa31 and siwenshao April 14, 2026 07:29

navyaa31 approved these changes Apr 14, 2026

View reviewed changes

navyaa31 added 3 commits April 14, 2026 11:24

resolving merge conflicts

5f2110f

search bar for filters bug

aff7bda

ran npm install

38467e1

navyaa31 merged commit 8b72dc0 into main Apr 14, 2026
3 checks passed

Conversation

YoChang410 commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Testing

Confirmation of Change

Uh oh!

navyaa31 left a comment

Choose a reason for hiding this comment

Uh oh!

navyaa31 Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

navyaa31 Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

navyaa31 left a comment

Choose a reason for hiding this comment

Uh oh!

navyaa31 Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

navyaa31 Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

navyaa31 Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

CharlieSuarezRobles left a comment

Choose a reason for hiding this comment

Uh oh!

siwenshao Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

siwenshao Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

siwenshao left a comment

Choose a reason for hiding this comment

Uh oh!

CharlieSuarezRobles left a comment

Choose a reason for hiding this comment

Uh oh!

navyaa31 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

YoChang410 commented Mar 2, 2026 •

edited

Loading

github-actions Bot commented Apr 3, 2026 •

edited

Loading