[#305] feat: Revisión y validación de ErrorBoundary#312
Open
JulianFassetta wants to merge 4 commits intodevelopmentfrom
Hidden character warning
The head ref may contain hidden characters: "305-feat-revisi\u00f3n-y-validaci\u00f3n-de-los-errorboundary"
Open
[#305] feat: Revisión y validación de ErrorBoundary#312JulianFassetta wants to merge 4 commits intodevelopmentfrom
JulianFassetta wants to merge 4 commits intodevelopmentfrom
Conversation
JulianFassetta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descripción
Se agregaron ErrorBoundary a la aplicación, usando la librería react-error-boundary
Explicación
Se creó un componente de ErrorBoundary con ayuda de la librería react-error-boundary. Cualquier error que ocurra durante el renderizado de los componentes hijos será capturado, evitando que la aplicación completa se rompa
Cuando se detecta un error, se muestra así
Por las dudas, si en algun momento queremos mostrar diferente las cosas en los distintos módulos, le hice un variant. Así se ve ahora en los demás módulos:
Admin:
Teacher:
Student:
Y si, es responsive
El ErrorBoundary se aplicó en:
Issue relacionada
Closes #305