head.S: move skl_info and bootloader_data fields back#25
Open
m-iwanicki wants to merge 1 commit intoskl-loader-amdsl-noblobfrom
Open
head.S: move skl_info and bootloader_data fields back#25m-iwanicki wants to merge 1 commit intoskl-loader-amdsl-noblobfrom
m-iwanicki wants to merge 1 commit intoskl-loader-amdsl-noblobfrom
Conversation
Fixes issue: ``` loader/slaunch/skl.c:117:slaunch: Possible SKL module measures bootloader data: 16424 (measured prefix) > 170 (data offset) error: SKL module isn't correct. ``` Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>
Member
|
I think this should be changed on GRUB side instead. The size of |
Member
|
I agree that updating this in GRUB a better place in the long run. Can use this modification for testing though since commits are WIP anyway and it should be easier than bumping GRUB. |
Member
|
By the way, it may be useful to try to change those (presumed) CPUIDs to match the CPU used for testing. I didn't find any documentation as to what those are used by, it may be possible that PSP validates those somehow, but maybe they were meant for whatever loads the binary (GRUB in our case). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue:
Tested with
tb-devGRUB (meta-trenchboot)