loader/multiboot_mbi2.c: disable UEFI BS when booting with slaunch#27
Closed
krystian-hebel wants to merge 1 commit intoaem-qubes-4.2.3-rebasefrom
Closed
loader/multiboot_mbi2.c: disable UEFI BS when booting with slaunch#27krystian-hebel wants to merge 1 commit intoaem-qubes-4.2.3-rebasefrom
krystian-hebel wants to merge 1 commit intoaem-qubes-4.2.3-rebasefrom
Conversation
MLE (kernel or Xen) can't use pre-DLE services, as those are not measured as part of DRTM. To make sure this is true, disable boot services before MBI is created, which will ensure that all required data is obtained and saved in MBI while it is available. BS are disabled before call to grub_multiboot2_get_mbi_size(), so the amount of allocated memory will be sufficient. Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com>
Member
|
Closing in favor of merged #28. The approach here is simpler, but it doesn't work well in practice because neither Xen nor Linux in Dom0 expect to boot this way and end up confused trying to do a legacy boot on an EFI system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MLE (kernel or Xen) can't use pre-DLE services, as those are not measured as part of DRTM. To make sure this is true, disable boot services before MBI is created, which will ensure that all required data is obtained and saved in MBI while it is available.
BS are disabled before call to grub_multiboot2_get_mbi_size(), so the amount of allocated memory will be sufficient.