Sort: Replace sort selector with popup card containing sort options#667
Open
mchen11077 wants to merge 1 commit into
Open
Sort: Replace sort selector with popup card containing sort options#667mchen11077 wants to merge 1 commit into
mchen11077 wants to merge 1 commit into
Conversation
Contributor
Cloudflare Pages preview
|
conradarcturus
approved these changes
Jun 15, 2026
conradarcturus
left a comment
conradarcturus
left a comment
Collaborator
There was a problem hiding this comment.
Some minor edits but otherwise lgtm.
Do you think we should add any explanations to the component or is it okay just as selectors?
| body={() => ( | ||
| <div style={{ display: 'flex', flexDirection: 'column', gap: '0.5em' }}> | ||
| <SortBySelector /> | ||
| <SecondarySortBySelector /> |
Collaborator
There was a problem hiding this comment.
The label right now is "Secondary Sort By" do you think the label "Tie breaker" would be easier to understand? Otherwise we can keep it as-is.
| description="Change how items are sorted." | ||
| title="Sort" | ||
| body={() => ( | ||
| <div style={{ display: 'flex', flexDirection: 'column', gap: '0.5em' }}> |
Collaborator
There was a problem hiding this comment.
Let's keep the selectors in line, add
width: 'max-content',
alignItems: 'flex-end',
| const { sortBy } = usePageParams(); | ||
|
|
||
| return ( | ||
| <div className="selector" style={{ gap: '0.25em' }}> |
Collaborator
There was a problem hiding this comment.
Add flexWrap: 'nowrap'
| <ArrowDownUpIcon size="1.2em" /> | ||
| <PopupCard | ||
| buttonLabel={<>{sortBy} ▶</>} | ||
| buttonClassName="selected" |
Collaborator
There was a problem hiding this comment.
The semantic category you want here is "primary". Selected should be only used when there are multiple options.
Suggested change
| buttonClassName="selected" | |
| buttonClassName="primary" |
| <PopupCard | ||
| buttonLabel={<>{sortBy} ▶</>} | ||
| buttonClassName="selected" | ||
| buttonStyle={getOptionStyle(SelectorDisplay.Dropdown, true, PositionInGroup.Standalone)} |
Collaborator
There was a problem hiding this comment.
Interesting use! makes sense. Thanks for re-using styles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #579
Summary
SortPopupCardthat contains Sort By, Secondary Sort By, and Sort Direction.showLabelprop fromSortBySelector.