Fix/verification#1441
Open
huseyincavusbi wants to merge 6 commits into
Open
Conversation
…an also be multimodal (AutoModelForImageTextToText)
…attn/PLE/rotary_emb can't be tested in isolation
…ng instead of bridge_model.blocks
…ry is top-level, only _test_component handles it)
Collaborator
|
Looks good! One small suggestion: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes three verification bugs found during Gemma4 adapter testing:
Component benchmark false failures — Models using
DelegatedAttentionBlockBridge(Gemma4) reported 81-96 component failures per model, dragging P1 from 100% to 50%. These are benchmark infrastructure failures. The component comparison can't call delegated attention/rotary/PLE modules in isolation because they require model-specific kwargs the benchmark doesn't provide. Added skip logic incomponent_outputs.pythat detectsDelegatedAttentionBlockBridge(via missinghook_q_inputin hook aliases) and skips untestable components (attn, rotary_emb, per_layer projections). The gold-standardforward_pass_logitstest was already passing. This just stops the benchmark from reporting false negatives.Phase 2 empty header —
main_benchmark.pyprinted a "PHASE 2:" header with zero tests on every run regardless of whether Phase 2 was selected. Moved the header inside theshould_run_phase(2)guard.Misleading "encoder-decoder" warning — The HF model loading log printed "for encoder-decoder model" for multimodal architectures using
AutoModelForImageTextToText. Removed the incorrect label.Verification (tiny-random/gemma-4-e):
Type of change
Checklist: