🗃️ delete duplicate checkins; add unique key#4695
Draft
MrKrisKrisu wants to merge 1 commit into
Draft
Conversation
Member
Author
|
Note: This PR is currently on hold. To avoid deleting user data without permission, I would like to create a separate PR to give users with duplicate check-ins the opportunity to clean this up themselves first. I would then notify the users and set a deadline. After the deadline, I would merge this PR and delete the duplicate check-ins. |
Member
Author
|
Blog post published: https://blog.traewelling.de/posts/duplicate-checkins/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2876
I would like to add a UNIQUE constraint to the database to prevent duplicate check-ins. Unfortunately, this has been possible (again) since 2024, as the UNIQUE constraint was accidentally deleted.
My approach:
This migration checks for duplicate check-ins. (= A user checked in at the same station at the same time during a trip.)
The oldest check-in (lowest ID) is keept; the others are deleted.
However, I don’t want to run this without first opening it up for discussion. Do you see any issues with this?