Fix calculation of multipart S3 upload chunk size (continues #1648)#2091
Open
MarcusSorealheis wants to merge 1 commit intoTraceMachina:mainfrom
Open
Fix calculation of multipart S3 upload chunk size (continues #1648)#2091MarcusSorealheis wants to merge 1 commit intoTraceMachina:mainfrom
MarcusSorealheis wants to merge 1 commit intoTraceMachina:mainfrom
Conversation
MarcusSorealheis
force-pushed
the
s3_fix
branch
from
6c4d6ce to
52ea555
Compare
- Add check for maximum file size - Calculate minimum chunk size (maximum chunk count) for multipart S3 file upload, checking for proper limit of chunk count before upload - Make MAX_UPLOAD_PARTS u64 for uniformity and simplicity Co-authored-by: Marcus <marcuseagan@gmail.com>
MarcusSorealheis
force-pushed
the
s3_fix
branch
from
52ea555 to
135b0c7
Compare
MarcusSorealheis
changed the title
palfrey
requested changes
Feb 13, 2026
Member
palfrey
left a comment
palfrey
left a comment
There was a problem hiding this comment.
One minor issue. Although, TBH if anyone's trying to upload 5TB objects in one go, problems will probably get hit anyways, let alone the 48.8TB ones!
|
|
||
| // S3 object cannot be larger than this number. See: | ||
| // https://docs.aws.amazon.com/AmazonS3/latest/userguide/qfacts.html | ||
| const MAX_UPLOAD_SIZE: u64 = 5 * 1024 * 1024 * 1024 * 1024; // 5TB. |
Member
There was a problem hiding this comment.
That page details the max part size as 48.8 TiB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #1425
Continues: #1648
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
Testing it now.
Checklist
bazel test //...passes locallygit amendsee some docsThis change is