2026-03-24 flake update by palfrey · Pull Request #2041 · TraceMachina/nativelink

palfrey · 2025-11-11T19:22:26Z

Description

Bring all the nixpkgs up-to-date, as we were running things ~1 year old, and it blocks a variety of security fixes due to needing a more recent Rust version. This PR brings us up to 1.93.1.

It also contains

A bunch of minor Rust changes that clippy now complains about. Some are "this was always a bit bad" and some are "newer Rust now supports a better syntax"
A few things that are "nixpkgs upgraded, so we need to fix things". So, playwright upgrade, disabling gci because it's broken now, working around a renovate issue on Macs
A lot of Bazel rule upgrades

Type of change

Please delete options that aren't relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

CI, bazel test //...

Checklist

Updated documentation if needed
Tests added/amended
bazel test //... passes locally
PR is contained in a single commit, using git amend see some docs

This change is

palfrey · 2025-11-11T19:43:27Z

              pkgs.gnutar
              pkgs.gzip
-              pkgs.python3Full
+              pkgs.python3


Removed NixOS/nixpkgs#433833

palfrey · 2025-11-11T19:46:45Z

              [p.cacert]
              ++ pkgs.lib.optionals p.stdenv.targetPlatform.isDarwin [
-                p.darwin.apple_sdk.frameworks.Security
+                p.apple-sdk.frameworks.Security


apple_sdk got redone. See https://nixos.org/manual/nixpkgs/stable/#sec-darwin-legacy-frameworks

palfrey · 2026-03-02T10:53:34Z

Mac issues are because of NixOS/nixpkgs#487193

palfrey · 2026-03-27T16:57:36Z

Re-enabled the local part of this so I could check I wasn't breaking it, because I did repeatedly during this PR

palfrey · 2026-03-27T16:59:35Z

-                                    }
+                                if let Some(key_value) = fields.get(field)
+                                    && *key_value == Value::BulkString(value.as_bytes().to_vec())
+                                {


Most of the code changes are due to newer rust letting you merge an if let and other if expression as one line now, and clippy complaining if you don't

palfrey · 2026-03-27T16:59:58Z

            CLIENT_OPERATION_ID.into(),
            worker_awaited_action.action_info().clone(),
-            Duration::from_secs(60),
+            Duration::from_mins(1),


Again, newer clippy complaint

palfrey · 2026-03-27T17:01:20Z

            })?;
            stores.insert(
-                config.instance_name.to_string(),
+                config.instance_name.clone(),


Clippy complains about these, probably because it's better to be explicit that this requires a clone v.s. looking like a possibly cheaper operation. To be clear, it's not doing anything different, it's just clearer.

palfrey · 2026-03-27T17:01:57Z

 const ACCOUNT_KEY_ENV_VAR: &str = "AZURE_STORAGE_KEY";

-enum BufferedBodyState {
+pub(crate) enum BufferedBodyState {


These were private but used by something pub(crate) which was bad.

palfrey · 2026-03-27T17:05:10Z

    name: Coverage
    runs-on: xlarge-ubuntu-24.04
-    timeout-minutes: 45
+    timeout-minutes: 180


Probably not needed anymore as this was actually a build problem, but nice to have just in case

palfrey · 2026-03-27T17:05:22Z

-          sudo rm -rf ~/Library/Developer/CoreSimulator/Caches/*
-        else
-          echo "Nothing to do here."
-        fi


Breaks with new MacOS sometimes

palfrey · 2026-03-27T17:05:33Z

 build --@rules_rust//:clippy_flag=-Dclippy::todo
 build --@rules_rust//:clippy_flag=-Aclippy::too_long_first_doc_paragraph
-build --@rules_rust//:clippy_flag=-Dclippy::unchecked_duration_subtraction
+build --@rules_rust//:clippy_flag=-Dclippy::unchecked_time_subtraction


Upstream renamed this

palfrey had a problem deploying to production November 11, 2025 19:22 — with GitHub Actions Failure

palfrey force-pushed the flake-update-2025-11-11 branch from a93983c to 9aed8d3 Compare November 11, 2025 19:34

palfrey had a problem deploying to production November 11, 2025 19:34 — with GitHub Actions Failure

palfrey force-pushed the flake-update-2025-11-11 branch from 9aed8d3 to c06248d Compare November 11, 2025 19:42

palfrey had a problem deploying to production November 11, 2025 19:42 — with GitHub Actions Failure

palfrey commented Nov 11, 2025

View reviewed changes

Comment thread flake.nix

pkgs.gnutar

pkgs.gzip

pkgs.python3Full

pkgs.python3

Copy link
Copy Markdown

Member Author

palfrey Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed NixOS/nixpkgs#433833

palfrey commented Nov 11, 2025

View reviewed changes

palfrey force-pushed the flake-update-2025-11-11 branch from c06248d to 614afaf Compare November 11, 2025 19:50

palfrey had a problem deploying to production November 11, 2025 19:51 — with GitHub Actions Failure

palfrey force-pushed the flake-update-2025-11-11 branch from 614afaf to b61c01c Compare November 12, 2025 11:22

palfrey had a problem deploying to production November 12, 2025 11:22 — with GitHub Actions Failure

palfrey force-pushed the flake-update-2025-11-11 branch from b61c01c to a77b36b Compare November 12, 2025 12:00

palfrey had a problem deploying to production November 12, 2025 12:00 — with GitHub Actions Failure

palfrey force-pushed the flake-update-2025-11-11 branch from a77b36b to fe81aac Compare November 12, 2025 13:07

palfrey had a problem deploying to production November 12, 2025 13:07 — with GitHub Actions Failure

2025-11-11 flake update

aa51477

palfrey force-pushed the flake-update-2025-11-11 branch from fe81aac to aa51477 Compare November 12, 2025 15:40

palfrey temporarily deployed to production November 12, 2025 15:40 — with GitHub Actions Inactive

palfrey had a problem deploying to production November 12, 2025 15:40 — with GitHub Actions Failure

palfrey mentioned this pull request Jan 16, 2026

chore(deps): update rust crate aws-sdk-s3 to v1.112.0 [security] #2107

Closed

1 task

palfrey added 3 commits January 23, 2026 17:50

rust-std apple update

29064eb

Merge branch 'main' into flake-update-2025-11-11

3b7d7a3

Fix native-cli deps

9d1da74

Ignore buildifier warnings

d76caa0

palfrey had a problem deploying to production February 26, 2026 16:38 — with GitHub Actions Failure

Merge branch 'main' into flake-update-2025-11-11

591a4dd

palfrey mentioned this pull request Mar 19, 2026

Update Rust crate zip to v8 #2230

Closed

1 task

palfrey added 10 commits March 24, 2026 13:32

nixpkgs 2026-03-24

2b6239d

Merge branch 'main' into flake-update-2025-11-11

9fb4929

Latest rust nightly

9bcaa0f

Upgrade buck2 rust

50b32ca

Fix ASAN issues with private RequestComponents

a8228ee

Newer rust build fixes

6160acb

Upgrade apple sdk to 14

6542473

Use mimalloc v3

47b5483

Disable macos_minimum_os_feature

3e17de1

Reset cc/libc versions

a0970e3

palfrey mentioned this pull request Mar 25, 2026

Upgrade to MacOS 26 on runners #2245

Merged

5 tasks

palfrey added 4 commits March 27, 2026 13:56

Merge branch 'main' into flake-update-2025-11-11

9b07c61

Newer rust fixes

a051ccc

Update free-disk-space

f0cb912

Set macos-sdk-version for mimalloc

d2f7826

palfrey commented Mar 27, 2026

View reviewed changes

MarcusSorealheis approved these changes Mar 30, 2026

View reviewed changes

palfrey mentioned this pull request Mar 31, 2026

Various security updates including aws-sdk-* #2256

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2026-03-24 flake update#2041

2026-03-24 flake update#2041
palfrey merged 51 commits intoTraceMachina:mainfrom
palfrey:flake-update-2025-11-11

palfrey commented Nov 11, 2025 •

edited

Loading

Uh oh!

palfrey Nov 11, 2025

Uh oh!

palfrey Nov 11, 2025

Uh oh!

palfrey commented Mar 2, 2026

Uh oh!

palfrey Mar 27, 2026

Uh oh!

palfrey Mar 27, 2026

Uh oh!

palfrey Mar 27, 2026

Uh oh!

palfrey Mar 27, 2026

Uh oh!

palfrey Mar 27, 2026

Uh oh!

palfrey Mar 27, 2026

Uh oh!

palfrey Mar 27, 2026

Uh oh!

palfrey Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

palfrey commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

palfrey commented Mar 2, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

palfrey commented Nov 11, 2025 •

edited

Loading