This repository was archived by the owner on Mar 9, 2023. It is now read-only.
use unified Ti.UI.createRefreshControl API for iOS & Android#75
Open
0x6e69636f wants to merge 1 commit intoTopener:masterfrom
Open
use unified Ti.UI.createRefreshControl API for iOS & Android#750x6e69636f wants to merge 1 commit intoTopener:masterfrom
0x6e69636f wants to merge 1 commit intoTopener:masterfrom
Conversation
Owner
|
Thanks! However, I want to deprecate this widget in general, but it needs to be kept as-is for Next to that, setting the text can be done manually easily with the current implementation by using Let me know what you think |
Author
|
Hey, thanks for my late reply |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just removed the
if(OS_IOS)andif(OS_ANDROID)tests and Android specific code because since this change, we can now useTi.UI.createRefreshControlon both platformSee
6.2.0.GAchangelogof course I invite you to test this, since I just made the fix and am testing this on my app, working fine so far