Skip to content

Commit d643580

Browse files
author
DavidQ
committed
Promote preview.html into Preview Generator V2 tool preserving behavior and aligning to Palette Manager layout - PR_26126_009-preview-generator-v2-from-preview-htm.l
1 parent 9198137 commit d643580

10 files changed

Lines changed: 10233 additions & 861 deletions

File tree

docs/dev/codex_commands.md

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,25 @@
1-
# Codex Commands - PR_26126_008-preview-generator-v2-first-pass
1+
# Codex Commands - PR_26126_010-preview-generator-v2-reskin-correction
22

33
```bash
4-
codex run "Create PR_26126_008-preview-generator-v2-first-pass. Build Preview Generator V2 in one pass using Palette Manager as the base layout/code pattern. Use the exact Palette Manager platform header and NAV style. NAV buttons must be Generate Preview, Apply to Game, Export Image, with Generate Preview in NAV. Do not show JSON UI. Preview Generator V2 owns no schema. Implement native radio target selection with name=\"previewTarget\" and values including game. Build 3-column UI: left target/source/status, center main preview plus Last Generated Preview at bottom, right render/output controls. For Game target, generated preview should update asset-browser-compatible destination data for that game, validated against the destination schema only. No fallback data, no hidden defaults, no partial render on invalid destination data. Include targeted Playwright coverage for skeleton render, radio selection, generate/apply/export button states, and no visible JSON controls. Do not modify samples. Produce review artifacts."
4+
codex run "Create PR_26126_010-preview-generator-v2-reskin-correction. Correct Preview Generator V2 as a reskin of existing preview.html, not a rewrite. Review and preserve all existing preview.html functionality, labels, inputs, ids where possible, and behavior. Regroup the existing controls into the Palette Manager-style layout. Left column must contain: Repo Destination (rename Game Destination; it opens a folder, not a file), Target Source, and Render Controls. Center column must replace Main Preview with Paths or IDs using an input box. Right column must place Status under Output Summary. Header/NAV must remove Apply to Game and Export Image; keep Generate Preview only in the Palette Manager-style NAV. Do not add JSON UI. Do not create a Preview Generator V2 schema. Do not modify samples. Update Playwright/tests only for this corrected reskin behavior. Produce review artifacts."
55
```
66

77
## Validation Commands
88

99
```bash
10-
node --check tools/preview/main.js
11-
node --check tools/preview/previewGeneratorShell.js
10+
node --check tools/preview-generator-v2/main.js
11+
node --check tools/preview-generator-v2/previewGeneratorShell.js
1212
node --check tests/tools/PreviewGeneratorV2FirstPass.test.mjs
1313
node tests/tools/PreviewGeneratorV2FirstPass.test.mjs
14-
git diff --check -- tools/preview/index.html tools/preview/main.js tools/preview/previewGeneratorShell.js tools/preview/previewGeneratorV2.css tests/tools/PreviewGeneratorV2FirstPass.test.mjs docs/dev/codex_commands.md docs/dev/commit_comment.txt
14+
git diff --check -- tools/preview-generator-v2/index.html tools/preview-generator-v2/main.js tools/preview-generator-v2/previewGeneratorShell.js tools/preview-generator-v2/previewGeneratorV2.css tools/toolRegistry.js tests/tools/PreviewGeneratorV2FirstPass.test.mjs docs/dev/codex_commands.md docs/dev/commit_comment.txt
15+
npm run test:workspace-v2
1516
npm run codex:review-artifacts
1617
```
1718

18-
## Playwright
19+
## Notes
1920

20-
Targeted Playwright coverage is in `tests/tools/PreviewGeneratorV2FirstPass.test.mjs`.
21+
`tools/preview/preview_svg_generator.html` was used as the existing preview generator base because there is no literal `preview.html` file in the repository.
2122

22-
## Full Samples
23+
`npm run test:workspace-v2` was attempted, but the script is not defined in this checkout.
2324

24-
Full samples smoke test was skipped because this PR is scoped to the Preview Generator V2 tool and targeted Playwright coverage.
25+
Full samples smoke test was skipped because this PR is scoped to Preview Generator V2.

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Build Preview Generator V2 first-pass UI and coverage - PR_26126_008-preview-generator-v2-first-pass
1+
Correct Preview Generator V2 reskin layout - PR_26126_010-preview-generator-v2-reskin-correction
Lines changed: 19 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,24 @@
11
# git status --short
22
M docs/dev/codex_commands.md
33
M docs/dev/commit_comment.txt
4-
A tests/tools/PreviewGeneratorV2FirstPass.test.mjs
5-
A tools/preview/index.html
6-
A tools/preview/main.js
7-
A tools/preview/previewGeneratorShell.js
8-
A tools/preview/previewGeneratorV2.css
4+
M docs/dev/reports/codex_changed_files.txt
5+
M docs/dev/reports/codex_review.diff
6+
M tests/tools/PreviewGeneratorV2FirstPass.test.mjs
7+
A tools/preview-generator-v2/index.html
8+
A tools/preview-generator-v2/main.js
9+
A tools/preview-generator-v2/previewGeneratorShell.js
10+
A tools/preview-generator-v2/previewGeneratorV2.css
11+
M tools/toolRegistry.js
912

1013
# git diff --stat
11-
docs/dev/codex_commands.md | 15 +-
12-
docs/dev/commit_comment.txt | 2 +-
13-
tests/tools/PreviewGeneratorV2FirstPass.test.mjs | 127 ++++++
14-
tools/preview/index.html | 171 ++++++++
15-
tools/preview/main.js | 493 +++++++++++++++++++++
16-
tools/preview/previewGeneratorShell.js | 186 ++++++++
17-
tools/preview/previewGeneratorV2.css | 534 +++++++++++++++++++++++
18-
7 files changed, 1521 insertions(+), 7 deletions(-)
14+
docs/dev/codex_commands.md | 19 +-
15+
docs/dev/commit_comment.txt | 2 +-
16+
docs/dev/reports/codex_changed_files.txt | 32 +-
17+
docs/dev/reports/codex_review.diff | 6646 ++++++++++++++++++--
18+
tests/tools/PreviewGeneratorV2FirstPass.test.mjs | 144 +-
19+
tools/preview-generator-v2/index.html | 188 +
20+
tools/preview-generator-v2/main.js | 932 +++
21+
.../preview-generator-v2/previewGeneratorShell.js | 186 +
22+
tools/preview-generator-v2/previewGeneratorV2.css | 490 ++
23+
tools/toolRegistry.js | 18 +
24+
10 files changed, 8041 insertions(+), 616 deletions(-)

0 commit comments

Comments
 (0)