Skip to content

Commit 9198137

Browse files
author
DavidQ
committed
Build first-pass Preview Generator V2 with Palette Manager layout and destination-schema behavior - PR_26126_008-preview-generator-v2-first-pass
1 parent bf8f6f7 commit 9198137

10 files changed

Lines changed: 3095 additions & 438 deletions

docs/dev/codex_commands.md

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,24 @@
1-
# Codex Commands - PR_26126_007-preview-generator-v2-radio-contract
1+
# Codex Commands - PR_26126_008-preview-generator-v2-first-pass
22

33
```bash
4-
codex run "Create PR_26126_007-preview-generator-v2-radio-contract. Update Preview Generator V2 design docs to explicitly require native HTML radio inputs for target selection using <input type=\"radio\" name=\"group1\" value=\"...\"> pattern. Define that all target modes (e.g., Game) must use this radio group, no custom UI controls, no dropdowns, no toggles. Specify that selection drives destination schema behavior (e.g., Game updates asset-browser schema JSON preview field). Reinforce no fallback and no schema ownership. No implementation code. Do not modify samples. Produce review artifacts."
4+
codex run "Create PR_26126_008-preview-generator-v2-first-pass. Build Preview Generator V2 in one pass using Palette Manager as the base layout/code pattern. Use the exact Palette Manager platform header and NAV style. NAV buttons must be Generate Preview, Apply to Game, Export Image, with Generate Preview in NAV. Do not show JSON UI. Preview Generator V2 owns no schema. Implement native radio target selection with name=\"previewTarget\" and values including game. Build 3-column UI: left target/source/status, center main preview plus Last Generated Preview at bottom, right render/output controls. For Game target, generated preview should update asset-browser-compatible destination data for that game, validated against the destination schema only. No fallback data, no hidden defaults, no partial render on invalid destination data. Include targeted Playwright coverage for skeleton render, radio selection, generate/apply/export button states, and no visible JSON controls. Do not modify samples. Produce review artifacts."
55
```
66

77
## Validation Commands
88

99
```bash
10-
git diff --check -- docs/pr/PR_26126_002-preview-tool-detailed-design.md docs/pr/PR_26126_003-preview-tool-layout-spec.md docs/dev/codex_commands.md docs/dev/commit_comment.txt
11-
rg -n 'name="group1"|previewTargetModeGame|dropdowns|toggles|asset-browser.schema.json|preview-generator-v2.schema.json' docs/pr/PR_26126_002-preview-tool-detailed-design.md docs/pr/PR_26126_003-preview-tool-layout-spec.md
10+
node --check tools/preview/main.js
11+
node --check tools/preview/previewGeneratorShell.js
12+
node --check tests/tools/PreviewGeneratorV2FirstPass.test.mjs
13+
node tests/tools/PreviewGeneratorV2FirstPass.test.mjs
14+
git diff --check -- tools/preview/index.html tools/preview/main.js tools/preview/previewGeneratorShell.js tools/preview/previewGeneratorV2.css tests/tools/PreviewGeneratorV2FirstPass.test.mjs docs/dev/codex_commands.md docs/dev/commit_comment.txt
1215
npm run codex:review-artifacts
1316
```
1417

1518
## Playwright
1619

17-
No Playwright impact. This PR is a documentation-only radio contract correction and does not modify implementation code.
20+
Targeted Playwright coverage is in `tests/tools/PreviewGeneratorV2FirstPass.test.mjs`.
1821

1922
## Full Samples
2023

21-
Full samples smoke test was skipped because this PR is documentation-only and sample files are out of scope.
24+
Full samples smoke test was skipped because this PR is scoped to the Preview Generator V2 tool and targeted Playwright coverage.

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Define Preview Generator V2 native target radio contract - PR_26126_007-preview-generator-v2-radio-contract
1+
Build Preview Generator V2 first-pass UI and coverage - PR_26126_008-preview-generator-v2-first-pass
Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,18 @@
11
# git status --short
22
M docs/dev/codex_commands.md
33
M docs/dev/commit_comment.txt
4-
M docs/pr/PR_26126_002-preview-tool-detailed-design.md
5-
M docs/pr/PR_26126_003-preview-tool-layout-spec.md
4+
A tests/tools/PreviewGeneratorV2FirstPass.test.mjs
5+
A tools/preview/index.html
6+
A tools/preview/main.js
7+
A tools/preview/previewGeneratorShell.js
8+
A tools/preview/previewGeneratorV2.css
69

710
# git diff --stat
8-
docs/dev/codex_commands.md | 8 +--
9-
docs/dev/commit_comment.txt | 2 +-
10-
.../PR_26126_002-preview-tool-detailed-design.md | 69 ++++++++++++--------
11-
docs/pr/PR_26126_003-preview-tool-layout-spec.md | 73 ++++++++++++++--------
12-
4 files changed, 95 insertions(+), 57 deletions(-)
11+
docs/dev/codex_commands.md | 15 +-
12+
docs/dev/commit_comment.txt | 2 +-
13+
tests/tools/PreviewGeneratorV2FirstPass.test.mjs | 127 ++++++
14+
tools/preview/index.html | 171 ++++++++
15+
tools/preview/main.js | 493 +++++++++++++++++++++
16+
tools/preview/previewGeneratorShell.js | 186 ++++++++
17+
tools/preview/previewGeneratorV2.css | 534 +++++++++++++++++++++++
18+
7 files changed, 1521 insertions(+), 7 deletions(-)

0 commit comments

Comments
 (0)