Fix Object Vector Studio V2 scrolling, shape icons, grid zoom, palette validation, and Objects actions layout - PR_26132_021-object-vector-studio-v2-scroll-grid-palette-fixes

Author: DavidQ

docs/dev/reports/playwright_v8_coverage.txt

@@ -20,8 +20,8 @@ Exercised tool entry points detected:
 (0%) Workspace Manager - not exercised by this Playwright run
 
 Changed runtime JS files covered:
-(80%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 97/97; executed functions 4/5
-(89%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 3110/3110; executed functions 322/363
+(80%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 98/98; executed functions 4/5
+(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 3209/3209; executed functions 334/372
 (95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 401/401; executed functions 52/55
 (98%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - executed lines 914/914; executed functions 105/107
 
@@ -169,7 +169,7 @@ Files with executed line/function counts where available:
 (80%) src/engine/persistence/StorageService.js - executed lines 49/49; executed functions 4/5
 (80%) tools/asset-manager-v2/js/controls/AccordionSection.js - executed lines 27/27; executed functions 4/5
 (80%) tools/asset-manager-v2/js/controls/AssetFormControl.js - executed lines 563/563; executed functions 49/61
-(80%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 97/97; executed functions 4/5
+(80%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 98/98; executed functions 4/5
 (80%) tools/palette-manager-v2/modules/PaletteHistoryStack.js - executed lines 54/54; executed functions 8/10
 (80%) tools/preview-generator-v2/controls/AccordionSection.js - executed lines 31/31; executed functions 4/5
 (80%) tools/preview-generator-v2/PreviewGeneratorV2Logger.js - executed lines 19/19; executed functions 4/5
@@ -194,8 +194,8 @@ Files with executed line/function counts where available:
 (88%) tools/text2speech-V2/js/controls/TextInputControl.js - executed lines 24/24; executed functions 7/8
 (88%) tools/world-vector-studio-v2/js/controls/SourceInputControl.js - executed lines 33/33; executed functions 7/8
 (89%) tools/asset-manager-v2/js/services/AssetSchemaValidator.js - executed lines 295/295; executed functions 25/28
-(89%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 3110/3110; executed functions 322/363
 (89%) tools/preview-generator-v2/controls/StatusLogControl.js - executed lines 32/32; executed functions 8/9
+(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 3209/3209; executed functions 334/372
 (90%) tools/palette-manager-v2/modules/PaletteValidationService.js - executed lines 88/88; executed functions 9/10
 (90%) tools/text2speech-V2/js/controls/ActionNavControl.js - executed lines 117/117; executed functions 19/21
 (90%) tools/text2speech-V2/js/TextToSpeechToolApp.js - executed lines 807/807; executed functions 62/69
@@ -297,6 +297,6 @@ Changed JS files considered:
 (0%) tests/playwright/tools/WorkspaceManagerV2.spec.mjs - changed JS file not collected as browser runtime coverage
 (0%) tools/object-vector-studio-v2/tests/playwright/FirstClassToolStarter.spec.mjs - changed JS file not collected as browser runtime coverage
 (80%) tools/object-vector-studio-v2/js/bootstrap.js - changed JS file with browser V8 coverage
-(89%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed JS file with browser V8 coverage
+(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed JS file with browser V8 coverage
 (95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - changed JS file with browser V8 coverage
 (98%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - changed JS file with browser V8 coverage

docs/pr/PR_26132_021-object-vector-studio-v2-scroll-grid-palette-fixes.md

@@ -0,0 +1,93 @@
+# PR_26132_021-object-vector-studio-v2-scroll-grid-palette-fixes
+
+## Scope
+
+Updates Object Vector Studio V2 layout/control behavior and the Asteroids Object Vector asset tags only. No schema changes and no unrelated game changes.
+
+## Changes
+
+- Added left-column vertical scrolling.
+- Let `objectVectorStudioV2ShapeToolsContent` fill to the bottom of its accordion while preserving `accordion-v2__content object-vector-studio-v2__scroll-content`.
+- Added Words/Icons support and CSS icons for Bring Forward, Send Backward, Bring To Front, Send To Back, Group Shapes, and Ungroup.
+- Increased rectangle, circle, ellipse, arc, and polygon icon stroke weight and made those icons white.
+- Reworked the triangle icon to be unfilled with a white stroke matching rectangle stroke weight.
+- Removed the `asteroids` tag from Asteroids Object Vector Studio V2 asset library entries.
+- Removed the visible ` x` suffix from object tag pills and added numeric duplicate tag resolution.
+- Changed viewport zoom buttons and mouse wheel zoom to 10% steps, with clamped min/max reachability from 25% to 400%.
+- Moved grid rendering into SVG coordinates so it scales with the center dot and current viewBox.
+- Rejected non-palette paint/stroke colors with visible Status Log failures.
+- Kept Object action buttons inside the Objects accordion bottom and removed the separate Object Actions callout.
+- Kept Objects list overflow visible while the Objects container scrolls.
+- Put Tag Filter and Search labels/fields on one line.
+
+## Validation
+
+Playwright impacted: Yes.
+
+Commands run:
+
+- `node --check tools/object-vector-studio-v2/js/ToolStarterApp.js`
+- `node --check tools/object-vector-studio-v2/js/bootstrap.js`
+- `node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs`
+- `node --check tools/object-vector-studio-v2/tests/playwright/FirstClassToolStarter.spec.mjs`
+- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list --grep "shows Object Vector Studio V2 layout shell"`
+- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list --grep "expands Object Vector Studio V2 asset authoring"`
+- `npx playwright test --config tools/object-vector-studio-v2/playwright.config.mjs --reporter=list`
+- `npm run test:workspace-v2`
+
+Result:
+
+- Focused Object Vector Studio V2 layout/control coverage passed.
+- Tool-local Object Vector Studio V2 suite passed: 4 passed.
+- Full Workspace Manager V2 suite passed: 45 passed.
+- Playwright V8 coverage refreshed at `docs/dev/reports/playwright_v8_coverage.txt`.
+- Full samples smoke test skipped per request; this PR is limited to Object Vector Studio V2 layout/control behavior and Asteroids Object Vector asset tags.
+
+## Playwright Coverage
+
+Validates:
+
+- Left column scrolling.
+- Shape/Tools content reaches the accordion bottom.
+- Words/Icons affects z-order/group buttons.
+- White, heavier shape icons and unfilled triangle styling.
+- Asteroids `asteroids` tag removal from Object Vector asset entries.
+- Tag creation does not append ` x`, and duplicate tags receive numeric suffixes.
+- 10% zoom steps and mouse-wheel min/max zoom reachability.
+- SVG grid scales in the same coordinate surface as the center dot.
+- Non-palette paint/stroke colors are rejected.
+- Object actions are inside the Objects accordion bottom.
+- Objects list overflow stays visible while the Objects container scrolls.
+- Tag Filter and Search controls render as inline rows.
+
+Expected pass behavior:
+
+- Object Vector Studio V2 shows the requested scroll, grid, icon, tag, palette, and Object action behavior without schema drift or hidden fallback behavior.
+
+Expected fail behavior:
+
+- Missing payloads, missing palette, locked object edits, invalid transforms, and non-palette paint/stroke colors log visible/actionable WARN/FAIL entries and avoid partial mutation.
+
+## Manual Validation
+
+1. Open `tools/object-vector-studio-v2/index.html`.
+2. Load a valid Object Vector payload and runtime palette.
+3. Confirm the left column scrolls when content exceeds its height.
+4. Toggle Words/Icons and confirm z-order/group buttons switch with the shape buttons.
+5. Confirm rectangle, circle, ellipse, arc, and polygon icons are white with heavier strokes, and triangle is outline-only.
+6. Add a tag, then add the same tag again; confirm the first tag has no ` x` suffix and the duplicate gets a numeric suffix.
+7. Use Zoom In/Out and mouse wheel to confirm 10% zoom steps and min/max clamp at 25% and 400%.
+8. Toggle Grid and confirm the SVG grid scales with the center dot while zooming.
+9. Try applying a non-palette color through runtime state and confirm the Status Log rejects it.
+10. Confirm Object actions remain at the bottom of the Objects accordion and the filter/search controls are inline.
+
+Expected outcome:
+
+- The Object Vector Studio V2 editing surface behaves as requested with constrained scroll regions, valid palette-only paint/stroke operations, SVG-coordinate grid scaling, and no Asteroids asset-library `asteroids` tag.
+
+## Out Of Scope
+
+- No schema changes.
+- No unrelated game changes.
+- No World Vector Studio V2 changes.
+- No full samples smoke test.

games/Asteroids/game.manifest.json

@@ -218,37 +218,37 @@
                 "id": "asset.asteroids.ship",
                 "name": "Asteroids Ship",
                 "objectId": "object.asteroids.ship",
-                "tags": ["asteroids", "player", "ship"]
+                "tags": ["player", "ship"]
               },
               {
                 "id": "asset.asteroids.asteroid.large",
                 "name": "Large Asteroid",
                 "objectId": "object.asteroids.asteroid.large",
-                "tags": ["asteroids", "asteroid", "large"]
+                "tags": ["asteroid", "large"]
               },
               {
                 "id": "asset.asteroids.asteroid.medium",
                 "name": "Medium Asteroid",
                 "objectId": "object.asteroids.asteroid.medium",
-                "tags": ["asteroids", "asteroid", "medium"]
+                "tags": ["asteroid", "medium"]
               },
               {
                 "id": "asset.asteroids.asteroid.small",
                 "name": "Small Asteroid",
                 "objectId": "object.asteroids.asteroid.small",
-                "tags": ["asteroids", "asteroid", "small"]
+                "tags": ["asteroid", "small"]
               },
               {
                 "id": "asset.asteroids.ufo.large",
                 "name": "Large UFO",
                 "objectId": "object.asteroids.ufo.large",
-                "tags": ["asteroids", "ufo", "large"]
+                "tags": ["ufo", "large"]
               },
               {
                 "id": "asset.asteroids.ufo.small",
                 "name": "Small UFO",
                 "objectId": "object.asteroids.ufo.small",
-                "tags": ["asteroids", "ufo", "small"]
+                "tags": ["ufo", "small"]
               }
             ]
           },