Refine Object Vector Studio V2 object hierarchy, selection, paint/stroke controls, and preview zoom behavior - PR_26132_020-object-vector-studio-v2-selection-paint-controls

Author: DavidQ

docs/dev/reports/playwright_v8_coverage.txt

@@ -20,8 +20,10 @@ Exercised tool entry points detected:
 (0%) Workspace Manager - not exercised by this Playwright run
 
 Changed runtime JS files covered:
-(80%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 92/92; executed functions 4/5
-(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 2907/2907; executed functions 318/355
+(80%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 97/97; executed functions 4/5
+(89%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 3110/3110; executed functions 322/363
+(95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 401/401; executed functions 52/55
+(98%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - executed lines 914/914; executed functions 105/107
 
 Files with executed line/function counts where available:
 (2%) src/engine/input/ActionInputService.js - executed lines 397/397; executed functions 1/51
@@ -167,7 +169,7 @@ Files with executed line/function counts where available:
 (80%) src/engine/persistence/StorageService.js - executed lines 49/49; executed functions 4/5
 (80%) tools/asset-manager-v2/js/controls/AccordionSection.js - executed lines 27/27; executed functions 4/5
 (80%) tools/asset-manager-v2/js/controls/AssetFormControl.js - executed lines 563/563; executed functions 49/61
-(80%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 92/92; executed functions 4/5
+(80%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 97/97; executed functions 4/5
 (80%) tools/palette-manager-v2/modules/PaletteHistoryStack.js - executed lines 54/54; executed functions 8/10
 (80%) tools/preview-generator-v2/controls/AccordionSection.js - executed lines 31/31; executed functions 4/5
 (80%) tools/preview-generator-v2/PreviewGeneratorV2Logger.js - executed lines 19/19; executed functions 4/5
@@ -192,8 +194,8 @@ Files with executed line/function counts where available:
 (88%) tools/text2speech-V2/js/controls/TextInputControl.js - executed lines 24/24; executed functions 7/8
 (88%) tools/world-vector-studio-v2/js/controls/SourceInputControl.js - executed lines 33/33; executed functions 7/8
 (89%) tools/asset-manager-v2/js/services/AssetSchemaValidator.js - executed lines 295/295; executed functions 25/28
+(89%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 3110/3110; executed functions 322/363
 (89%) tools/preview-generator-v2/controls/StatusLogControl.js - executed lines 32/32; executed functions 8/9
-(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 2907/2907; executed functions 318/355
 (90%) tools/palette-manager-v2/modules/PaletteValidationService.js - executed lines 88/88; executed functions 9/10
 (90%) tools/text2speech-V2/js/controls/ActionNavControl.js - executed lines 117/117; executed functions 19/21
 (90%) tools/text2speech-V2/js/TextToSpeechToolApp.js - executed lines 807/807; executed functions 62/69
@@ -208,9 +210,9 @@ Files with executed line/function counts where available:
 (93%) tools/workspace-manager-v2/js/controls/ToolTilesControl.js - executed lines 137/137; executed functions 14/15
 (94%) games/shared/workspaceGameMetadataHydrator.js - executed lines 106/106; executed functions 16/17
 (94%) tools/common/PaletteSortService.js - executed lines 103/103; executed functions 17/18
-(95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 406/406; executed functions 52/55
+(95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 401/401; executed functions 52/55
 (95%) tools/session-inspector-v2/js/services/SessionInspectorV2StorageService.js - executed lines 142/142; executed functions 18/19
-(98%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - executed lines 919/919; executed functions 105/107
+(98%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - executed lines 914/914; executed functions 105/107
 (100%) games/Asteroids/entities/Asteroid.js - executed lines 72/72; executed functions 11/11
 (100%) games/Asteroids/flow/attract.js - executed lines 17/17; executed functions 1/1
 (100%) games/Asteroids/flow/highscore.js - executed lines 16/16; executed functions 1/1
@@ -295,4 +297,6 @@ Changed JS files considered:
 (0%) tests/playwright/tools/WorkspaceManagerV2.spec.mjs - changed JS file not collected as browser runtime coverage
 (0%) tools/object-vector-studio-v2/tests/playwright/FirstClassToolStarter.spec.mjs - changed JS file not collected as browser runtime coverage
 (80%) tools/object-vector-studio-v2/js/bootstrap.js - changed JS file with browser V8 coverage
-(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed JS file with browser V8 coverage
+(89%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed JS file with browser V8 coverage
+(95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - changed JS file with browser V8 coverage
+(98%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - changed JS file with browser V8 coverage

docs/pr/PR_26132_020-object-vector-studio-v2-selection-paint-controls.md

@@ -0,0 +1,90 @@
+# PR_26132_020-object-vector-studio-v2-selection-paint-controls
+
+## Scope
+
+Updates Object Vector Studio V2 selection, object typing, hierarchy display, paint/stroke controls, and direct schema/runtime references only. No sample JSON changes and no World Vector Studio V2 changes.
+
+## Changes
+
+- Replaced asset category with one singular Object type field that uses type-ahead suggestions from existing object types and tags.
+- Moved Object Actions to the bottom of the Objects accordion: Add, Rename, Duplicate, Delete.
+- Updated Rename so the object name and object id change together.
+- Reworked the Objects list into an `objects > object > shape` hierarchy with left-aligned text, selected object/shape highlighting, vertical scrolling, and icon-only eye/lock controls.
+- Removed the duplicated shape list from Object Details and removed duplicated preview shape buttons that already exist in the left control surface.
+- Moved z-order and grouping controls between Shape/Tools separators and kept shape tool buttons square with updated rectangle/circle/ellipse stroke weight and a five-sided polygon icon.
+- Added Select deselect behavior: clicking Select with a selected shape clears shape selection.
+- Added center mouse-wheel zoom on the Object Preview work surface.
+- Removed Current Color from Palette and added selected-color visual emphasis on the active swatch.
+- Implemented Paint and Stroke click behavior on shapes, including fill/stroke application, shift additive selection, alt eyedropper sampling, color swap, and default colors shortcuts.
+- Added keyboard shortcuts: `V` Select, `F` Paint/Fill, `S` Stroke, `I` Eyedropper, `X` Swap fill/stroke, and `D` Default colors.
+- Updated Object Vector Studio V2 docs to state that the paint/stroke model can scale later into shaders, gradients, patterns, neon, SVG export, and runtime rendering.
+- Updated Object Vector Studio V2 schema and direct runtime/schema services so `category` is rejected and durable object payloads use the singular `type` field.
+
+## Validation
+
+Playwright impacted: Yes.
+
+Commands run:
+
+- `node --check tools/object-vector-studio-v2/js/ToolStarterApp.js`
+- `node --check tools/object-vector-studio-v2/js/bootstrap.js`
+- `node --check tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js`
+- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list --grep "shows Object Vector Studio V2 layout shell"`
+- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list --grep "supports Object Vector Studio V2 asset library inheritance"`
+- `npm run test:workspace-v2`
+- `npx playwright test --config tools/object-vector-studio-v2/playwright.config.mjs --reporter=list`
+
+Result:
+
+- Focused Workspace Manager V2 Object Vector Studio checks passed.
+- Full Workspace Manager V2 suite passed: 45 passed.
+- Tool-local Object Vector Studio V2 suite passed: 4 passed.
+- Playwright V8 coverage refreshed at `docs/dev/reports/playwright_v8_coverage.txt`.
+- Full samples smoke test skipped per request; this PR is limited to Object Vector Studio V2 UI/control behavior and direct schema/runtime references, with Workspace V2 and tool-local Playwright coverage covering the impacted surface.
+
+## Playwright Coverage
+
+Validates:
+
+- Singular Object type type-ahead and asset category removal.
+- Rename updates object id.
+- Object/shape hierarchy selection and selected highlighting.
+- Icon-only eye/lock controls and Objects container scrolling.
+- Object Details no longer duplicates the shape list.
+- Object Preview no longer duplicates shape action buttons.
+- Shape z-order/group controls are between Shape/Tools separators.
+- Selected color visual effect.
+- Center mouse-wheel zoom.
+- Select deselect behavior.
+- Paint/stroke click behavior and keyboard shortcuts.
+
+Expected pass behavior:
+
+- Object Vector Studio V2 exposes one object type, displays a usable object/shape hierarchy, applies paint/stroke controls to selected shapes, and keeps schema/runtime payloads free of asset category data.
+
+Expected fail behavior:
+
+- Invalid object/category payload drift, missing palette, missing selection, locked object edits, and invalid transforms log visible/actionable WARN/FAIL entries and do not partially mutate or render invalid state.
+
+## Manual Validation
+
+1. Open `tools/object-vector-studio-v2/index.html`.
+2. Load a valid Object Vector payload and runtime/session palette.
+3. Confirm Object type is a single type-ahead field and no asset category control is visible.
+4. Add and rename an object, then confirm the object id changes with the name.
+5. Create shapes, select them from the Objects hierarchy, and confirm selected object/shape highlighting.
+6. Use eye/lock icons on object tiles and shape rows.
+7. Select Paint or Stroke, click shapes, and confirm fill/stroke values update.
+8. Use `V`, `F`, `S`, `I`, `X`, and `D` shortcuts and confirm the Status Log records the operation.
+9. Mouse-wheel over the center work surface and confirm zoom changes.
+
+Expected outcome:
+
+- Object Vector Studio V2 presents the requested hierarchy, selection, paint/stroke, and keyboard control model with no duplicated Object Details/Preview controls and no asset category payload persistence.
+
+## Out Of Scope
+
+- No sample JSON changes.
+- No World Vector Studio V2 changes.
+- No new major feature systems beyond the requested selection/paint control behavior.
+- No full samples smoke test.

games/Asteroids/game.manifest.json

@@ -218,42 +218,36 @@
                 "id": "asset.asteroids.ship",
                 "name": "Asteroids Ship",
                 "objectId": "object.asteroids.ship",
-                "category": "ship",
                 "tags": ["asteroids", "player", "ship"]
               },
               {
                 "id": "asset.asteroids.asteroid.large",
                 "name": "Large Asteroid",
                 "objectId": "object.asteroids.asteroid.large",
-                "category": "object",
                 "tags": ["asteroids", "asteroid", "large"]
               },
               {
                 "id": "asset.asteroids.asteroid.medium",
                 "name": "Medium Asteroid",
                 "objectId": "object.asteroids.asteroid.medium",
-                "category": "object",
                 "tags": ["asteroids", "asteroid", "medium"]
               },
               {
                 "id": "asset.asteroids.asteroid.small",
                 "name": "Small Asteroid",
                 "objectId": "object.asteroids.asteroid.small",
-                "category": "object",
                 "tags": ["asteroids", "asteroid", "small"]
               },
               {
                 "id": "asset.asteroids.ufo.large",
                 "name": "Large UFO",
                 "objectId": "object.asteroids.ufo.large",
-                "category": "enemy",
                 "tags": ["asteroids", "ufo", "large"]
               },
               {
                 "id": "asset.asteroids.ufo.small",
                 "name": "Small UFO",
                 "objectId": "object.asteroids.ufo.small",
-                "category": "enemy",
                 "tags": ["asteroids", "ufo", "small"]
               }
             ]

src/engine/rendering/ObjectVectorRuntimeAssetService.js

@@ -881,7 +881,6 @@ export class ObjectVectorRuntimeAssetService {
       const normalizedObject = {
         ...object,
         baseObjectId: typeof object.baseObjectId === "string" ? object.baseObjectId.trim() : undefined,
-        category: typeof object.category === "string" ? object.category.trim() : undefined,
         id: object.id.trim(),
         name: object.name.trim(),
         tags: Array.isArray(object.tags) ? object.tags.map((tag) => tag.trim()).filter(Boolean) : undefined,
@@ -910,9 +909,6 @@ export class ObjectVectorRuntimeAssetService {
       if (normalizedObject.baseObjectId === undefined) {
         delete normalizedObject.baseObjectId;
       }
-      if (normalizedObject.category === undefined) {
-        delete normalizedObject.category;
-      }
       if (normalizedObject.tags === undefined) {
         delete normalizedObject.tags;
       }
@@ -921,7 +917,6 @@ export class ObjectVectorRuntimeAssetService {
     if (normalized.assetLibrary) {
       normalized.assetLibrary = {
         assets: normalized.assetLibrary.assets.map((asset) => ({
-          category: asset.category.trim(),
           id: asset.id.trim(),
           name: asset.name.trim(),
           objectId: asset.objectId.trim(),