Skip to content

Commit bf8f6f7

Browse files
author
DavidQ
committed
Enforce native HTML radio button contract for Preview Generator V2 target selection - PR_26126_007-preview-generator-v2-radio-contract
1 parent 46cd2f3 commit bf8f6f7

6 files changed

Lines changed: 393 additions & 441 deletions

docs/dev/codex_commands.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
1-
# Codex Commands - PR_26126_006-preview-generator-v2-action-contract
1+
# Codex Commands - PR_26126_007-preview-generator-v2-radio-contract
22

33
```bash
4-
codex run "Create PR_26126_006-preview-generator-v2-action-contract. Correct the Preview Generator V2 design docs: Preview Generator V2 must not have its own schema. It launches without knowing the target purpose until the user selects a target radio option. Define the Game radio behavior: when Game is selected and a preview image is generated, the output updates the existing tools/schemas/tools/asset-browser.schema.json-compatible JSON by adding/updating the preview image for that game. Remove any requirement for tools/schemas/tools/preview-generator-v2.schema.json. Keep strict validation against the destination schema. No implementation code. Do not modify samples. Produce review artifacts."
4+
codex run "Create PR_26126_007-preview-generator-v2-radio-contract. Update Preview Generator V2 design docs to explicitly require native HTML radio inputs for target selection using <input type=\"radio\" name=\"group1\" value=\"...\"> pattern. Define that all target modes (e.g., Game) must use this radio group, no custom UI controls, no dropdowns, no toggles. Specify that selection drives destination schema behavior (e.g., Game updates asset-browser schema JSON preview field). Reinforce no fallback and no schema ownership. No implementation code. Do not modify samples. Produce review artifacts."
55
```
66

77
## Validation Commands
88

99
```bash
1010
git diff --check -- docs/pr/PR_26126_002-preview-tool-detailed-design.md docs/pr/PR_26126_003-preview-tool-layout-spec.md docs/dev/codex_commands.md docs/dev/commit_comment.txt
11-
rg -n 'html-js-gaming\.tool\.preview|Target `toolState`|Preview Generator V2 accepts only its own' docs/pr/PR_26126_002-preview-tool-detailed-design.md docs/pr/PR_26126_003-preview-tool-layout-spec.md
11+
rg -n 'name="group1"|previewTargetModeGame|dropdowns|toggles|asset-browser.schema.json|preview-generator-v2.schema.json' docs/pr/PR_26126_002-preview-tool-detailed-design.md docs/pr/PR_26126_003-preview-tool-layout-spec.md
1212
npm run codex:review-artifacts
1313
```
1414

1515
## Playwright
1616

17-
No Playwright impact. This PR is a documentation-only action contract correction and does not modify implementation code.
17+
No Playwright impact. This PR is a documentation-only radio contract correction and does not modify implementation code.
1818

1919
## Full Samples
2020

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Correct Preview Generator V2 destination action contract - PR_26126_006-preview-generator-v2-action-contract
1+
Define Preview Generator V2 native target radio contract - PR_26126_007-preview-generator-v2-radio-contract

docs/dev/reports/codex_changed_files.txt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ M docs/dev/codex_commands.md
55
M docs/pr/PR_26126_003-preview-tool-layout-spec.md
66

77
# git diff --stat
8-
docs/dev/codex_commands.md | 7 +-
9-
docs/dev/commit_comment.txt | 2 +-
10-
.../PR_26126_002-preview-tool-detailed-design.md | 68 ++++++++-
11-
docs/pr/PR_26126_003-preview-tool-layout-spec.md | 152 +++++++++++++++------
12-
4 files changed, 174 insertions(+), 55 deletions(-)
8+
docs/dev/codex_commands.md | 8 +--
9+
docs/dev/commit_comment.txt | 2 +-
10+
.../PR_26126_002-preview-tool-detailed-design.md | 69 ++++++++++++--------
11+
docs/pr/PR_26126_003-preview-tool-layout-spec.md | 73 ++++++++++++++--------
12+
4 files changed, 95 insertions(+), 57 deletions(-)

0 commit comments

Comments
 (0)