Skip to content

Commit 46cd2f3

Browse files
author
DavidQ
committed
Define Preview Generator V2 as action tool using destination schemas only - PR_26126_006-preview-generator-v2-action-contract
1 parent 675f320 commit 46cd2f3

6 files changed

Lines changed: 650 additions & 188 deletions

docs/dev/codex_commands.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,20 @@
1-
# Codex Commands - PR_26126_005-preview-generator-v2-naming
1+
# Codex Commands - PR_26126_006-preview-generator-v2-action-contract
22

33
```bash
4-
codex run "Create PR_26126_005-preview-generator-v2-naming. Update all Preview Generator V2 design docs to use the official name \"Preview Generator V2\". Ensure consistency across title, header (platformShell shortDescription usage), layout spec, and references to the tool. Do not change functionality. Do not modify samples. Update docs/pr files and produce review artifacts."
4+
codex run "Create PR_26126_006-preview-generator-v2-action-contract. Correct the Preview Generator V2 design docs: Preview Generator V2 must not have its own schema. It launches without knowing the target purpose until the user selects a target radio option. Define the Game radio behavior: when Game is selected and a preview image is generated, the output updates the existing tools/schemas/tools/asset-browser.schema.json-compatible JSON by adding/updating the preview image for that game. Remove any requirement for tools/schemas/tools/preview-generator-v2.schema.json. Keep strict validation against the destination schema. No implementation code. Do not modify samples. Produce review artifacts."
55
```
66

77
## Validation Commands
88

99
```bash
1010
git diff --check -- docs/pr/PR_26126_002-preview-tool-detailed-design.md docs/pr/PR_26126_003-preview-tool-layout-spec.md docs/dev/codex_commands.md docs/dev/commit_comment.txt
11+
rg -n 'html-js-gaming\.tool\.preview|Target `toolState`|Preview Generator V2 accepts only its own' docs/pr/PR_26126_002-preview-tool-detailed-design.md docs/pr/PR_26126_003-preview-tool-layout-spec.md
1112
npm run codex:review-artifacts
1213
```
1314

1415
## Playwright
1516

16-
No Playwright impact. This PR is a documentation naming consistency pass and does not modify implementation code.
17+
No Playwright impact. This PR is a documentation-only action contract correction and does not modify implementation code.
1718

1819
## Full Samples
1920

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Normalize Preview Generator V2 naming in design docs - PR_26126_005-preview-generator-v2-naming
1+
Correct Preview Generator V2 destination action contract - PR_26126_006-preview-generator-v2-action-contract

docs/dev/reports/codex_changed_files.txt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ M docs/dev/codex_commands.md
55
M docs/pr/PR_26126_003-preview-tool-layout-spec.md
66

77
# git diff --stat
8-
docs/dev/codex_commands.md | 8 +++----
9-
docs/dev/commit_comment.txt | 2 +-
10-
.../PR_26126_002-preview-tool-detailed-design.md | 18 +++++++-------
11-
docs/pr/PR_26126_003-preview-tool-layout-spec.md | 28 ++++++++++++----------
12-
4 files changed, 31 insertions(+), 25 deletions(-)
8+
docs/dev/codex_commands.md | 7 +-
9+
docs/dev/commit_comment.txt | 2 +-
10+
.../PR_26126_002-preview-tool-detailed-design.md | 68 ++++++++-
11+
docs/pr/PR_26126_003-preview-tool-layout-spec.md | 152 +++++++++++++++------
12+
4 files changed, 174 insertions(+), 55 deletions(-)

0 commit comments

Comments
 (0)