Fix Object Preview viewport pan behavior and enforce strict manifest schema validation - PR_26133_045-object-preview-pan-direction-and-strict-schema-fix

Author: DavidQ

docs/dev/reports/playwright_v8_coverage_report.md

@@ -1,6 +1,6 @@
-# PR_26133_044 Playwright V8 Coverage Report
+# PR_26133_045 Playwright V8 Coverage Report
 
-Task: PR_26133_044-remove-duplicated-object-vector-runtime-bindings
+Task: PR_26133_045-object-preview-pan-direction-and-strict-schema-fix
 Date: 2026-05-15
 
 ## Result
@@ -24,12 +24,10 @@ PASS - Coverage reporting was generated during `npm run test:workspace-v2`.
 ## Relevant Runtime Coverage
 
 ```text
-(98%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - executed lines 914/914; executed functions 106/108
-(52%) games/Asteroids/game/AsteroidsGameScene.js - executed lines 846/846; executed functions 25/48
+(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 3187/3187; executed functions 331/369
+(95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 409/409; executed functions 53/56
 ```
 
-The Asteroids runtime role helpers and asteroid geometry helper are exercised through the Asteroids gameplay rendering path and targeted node smoke checks; they are not surfaced as separate changed-runtime rows in the generated V8 summary.
-
 ## Guardrail
 
 ```text
@@ -38,4 +36,4 @@ The Asteroids runtime role helpers and asteroid geometry helper are exercised th
 
 ## PR-Specific Note
 
-The Workspace V2 run exercised Object Vector runtime manifest loading from `game.workspace.tools.object-vector-studio-v2.objects`, direct object ID role resolution, runtime rendering for asteroids/ship/UFO, and schema rejection of the removed `game.gameData.objectVectorRuntime` branch.
+The Workspace V2 run exercised Object Vector Studio V2 preview pan controls, center-dot visibility, coordinate/origin display updates, transform-origin pivot rendering, and strict schema rejection for unknown runtime/workspace fields.

docs/dev/reports/playwright_workspace_v2_results.md

@@ -1,6 +1,6 @@
-# PR_26133_044 Workspace V2 Playwright Results
+# PR_26133_045 Workspace V2 Playwright Results
 
-Task: PR_26133_044-remove-duplicated-object-vector-runtime-bindings
+Task: PR_26133_045-object-preview-pan-direction-and-strict-schema-fix
 Date: 2026-05-15
 
 ## Result
@@ -10,22 +10,22 @@ PASS - `npm run test:workspace-v2` completed successfully.
 - Command: `npm run test:workspace-v2`
 - Playwright target: `tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list`
 - Final result: 51 passed, 0 failed.
-- Runtime/console guard: Asteroids Object Vector runtime and Workspace Manager V2 tests completed with no reported page errors.
+- Runtime/console guard: Workspace Manager V2 and Object Vector Studio V2 scenarios completed with no reported page errors.
 
 ## PR-Specific Coverage
 
-- Verified Asteroids launches Object Vector runtime assets from `game.workspace.tools.object-vector-studio-v2.objects`.
-- Verified runtime role validation resolves `object.asteroids.*` IDs directly from the loaded Object Vector object list.
-- Verified `game.gameData.objectVectorRuntime` is absent from `games/Asteroids/game.manifest.json`.
-- Verified schema validation rejects a manifest when `game.gameData.objectVectorRuntime` is re-added.
-- Verified runtime rendering counts for asteroids, ship, and UFO remain active after removing the duplicate binding map.
+- Verified the Center control toggles the center dot without recentering or changing the viewport.
+- Verified Up/Down/Left/Right pan only the viewport origin and update the Canvas origin display.
+- Verified pan controls do not mutate selected shape geometry or transform state.
+- Verified pointer X/Y coordinate display remains logical after the viewport-origin display change.
+- Verified the transform origin/pivot marker reflects the applied origin used for rotation/scale behavior.
+- Verified `game.gameData.objectVectorRuntime` and unknown `gameData` fields fail strict schema validation.
+- Verified the workspace manifest schema rejects an unknown root field.
 
 ## Additional Validation
 
-- `node` manifest-schema check: current Asteroids manifest returned `{ ok: true }`.
-- `node` manifest-schema check: injected `game.gameData.objectVectorRuntime` returned `{ ok: false }`.
-- Targeted node smoke checks passed for `tests/games/AsteroidsPlatformDemo.test.mjs` and `tests/games/AsteroidsAssetReferenceAdoption.test.mjs`.
-
-## Notes
-
-- `npm test` is blocked before the node suite by the existing shared-extraction guard baseline drift; this PR did not touch those unrelated guard violations.
+- `node` JSON parse check passed for `tools/schemas/game.manifest.schema.json`, `tools/schemas/workspace.manifest.schema.json`, and `games/Asteroids/game.manifest.json`.
+- `node` schema-service check: current Asteroids manifest returned `{ ok: true }`.
+- `node` schema-service check: injected `game.gameData.objectVectorRuntime` returned `{ ok: false }`.
+- `node` schema-service check: injected `game.gameData.debugUnknown` returned `{ ok: false }`.
+- `node` schema-service check: injected workspace root `debugUnknown` returned `{ ok: false }`.

docs/dev/reports/strict_schema_unknown_field_validation_report.md

@@ -0,0 +1,34 @@
+# PR_26133_045 Strict Schema Unknown Field Validation Report
+
+Task: PR_26133_045-object-preview-pan-direction-and-strict-schema-fix
+Date: 2026-05-15
+
+## Schema Changes
+
+- `tools/schemas/game.manifest.schema.json` now sets `$defs.gameData.additionalProperties` to `false`.
+- The former dedicated `not` branch for `objectVectorRuntime` was removed because `gameData` now allows only explicit properties.
+- `objectVectorRuntime` was not added back to the schema or the Asteroids manifest.
+- `tools/schemas/workspace.manifest.schema.json` already rejects unknown root and `tools` map fields with `additionalProperties: false`.
+
+## Validation Proof
+
+The Workspace Manager V2 schema service was run against the current Asteroids manifest and targeted invalid clones.
+
+```text
+valid Asteroids game manifest: ok true
+valid Asteroids workspace manifest: ok true
+injected game.gameData.objectVectorRuntime: ok false
+message: root.game.gameData.objectVectorRuntime is not allowed
+injected game.gameData.debugUnknown: ok false
+message: root.game.gameData.debugUnknown is not allowed
+injected workspace root debugUnknown: ok false
+message: root.debugUnknown is not allowed
+```
+
+## Command
+
+```text
+node --input-type=module - < inline WorkspaceManagerV2ContextService schema validation script
+```
+
+The same rejection paths are also asserted in `tests/playwright/tools/WorkspaceManagerV2.spec.mjs` and covered by `npm run test:workspace-v2`.

tests/playwright/tools/WorkspaceManagerV2.spec.mjs

@@ -1823,18 +1823,27 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#objectVectorStudioV2RenderSurface [data-center-origin='0,0']")).toHaveCount(1);
       await expect(page.locator("#objectVectorStudioV2RenderSurface [data-center-origin='0,0']")).toHaveAttribute("r", "9");
       await expect(page.locator("#objectVectorStudioV2ViewportControls button")).toHaveText(["Out", "In", "Up", "Down", "Left", "Right", "View", "Center"]);
-      await expect(page.locator("#objectVectorStudioV2CenterDotButton")).not.toHaveAttribute("aria-pressed", /.*/);
+      await expect(page.locator("#objectVectorStudioV2CenterDotButton")).toHaveAttribute("aria-pressed", "true");
       await page.locator("#objectVectorStudioV2PanRightButton").click();
       await page.locator("#objectVectorStudioV2PanDownButton").click();
-      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 2, 2 | Canvas 0,0 centered | Zoom 100%");
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 2, 2 | Canvas origin -2,-2 from center | Zoom 100%");
       await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-1580 -1080 3200 2200");
       await page.locator("#objectVectorStudioV2RenderSurface").hover({ position: { x: 12, y: 12 } });
       await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toContainText("Pointer");
       await page.locator("#objectVectorStudioV2CenterDotButton").click();
+      await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-1580 -1080 3200 2200");
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toContainText("Canvas origin -2,-2 from center | Zoom 100%");
+      await expect(page.locator("#objectVectorStudioV2RenderSurface [data-center-origin='0,0']")).toHaveCount(0);
+      await expect(page.locator("#objectVectorStudioV2CenterDotButton")).toHaveAttribute("aria-pressed", "false");
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Center dot hidden\./);
+      await page.locator("#objectVectorStudioV2ResetViewButton").click();
       await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-1600 -1100 3200 2200");
-      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas 0,0 centered | Zoom 100%");
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas origin 0,0 centered | Zoom 100%");
+      await expect(page.locator("#objectVectorStudioV2RenderSurface [data-center-origin='0,0']")).toHaveCount(0);
+      await page.locator("#objectVectorStudioV2CenterDotButton").click();
       await expect(page.locator("#objectVectorStudioV2RenderSurface [data-center-origin='0,0']")).toHaveCount(1);
-      await expect(page.locator("#statusLog")).toHaveValue(/OK Viewport centered at origin 0,0; zoom 100% preserved\./);
+      await expect(page.locator("#objectVectorStudioV2CenterDotButton")).toHaveAttribute("aria-pressed", "true");
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Center dot visible\./);
       await expect(page.locator("#objectVectorStudioV2JsonDetails")).toContainText('"name": "Asteroids Ship"');
       await expect(page.locator("#objectVectorStudioV2JsonDetails")).toContainText('"selectedShape": null');
       await expect(page.locator("#objectVectorStudioV2JsonDetails")).not.toContainText('"palette"');
@@ -2366,6 +2375,14 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       const originAfterApply = await page.evaluate(() => window.__objectVectorStudioV2App.selectedShape().transform.origin);
       expect(originAfterApply).toEqual({ x: 2, y: -3 });
       await expect(page.locator("#statusLog")).toHaveValue(/OK Updated shape row 0 origin\/pivot to 2, -3\./);
+      const pivotMarkerAfterOrigin = await page.locator("#objectVectorStudioV2RenderSurface [data-pivot-origin='0']").evaluate((pivot) => {
+        const [horizontal, vertical] = Array.from(pivot.querySelectorAll("line"));
+        return {
+          x: Number(vertical.getAttribute("x1")),
+          y: Number(horizontal.getAttribute("y1"))
+        };
+      });
+      expect(pivotMarkerAfterOrigin).toEqual({ x: 120, y: 70 });
 
       await page.locator("#objectVectorStudioV2ScaleInput").fill("0");
       await expect(page.locator("#objectVectorStudioV2ScaleInput")).toHaveAttribute("aria-invalid", "true");
@@ -2521,25 +2538,25 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-1454.545 -1000 2909.091 2000");
       await page.locator("#objectVectorStudioV2PanRightButton").click();
       await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-1434.545 -1000 2909.091 2000");
-      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 2, 0 | Canvas 0,0 centered | Zoom 110%");
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 2, 0 | Canvas origin -2,0 from center | Zoom 110%");
       await page.locator("#objectVectorStudioV2ResetViewButton").click();
       await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-1600 -1100 3200 2200");
-      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas 0,0 centered | Zoom 100%");
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas origin 0,0 centered | Zoom 100%");
       await expect(page.locator("#statusLog")).toHaveValue(/OK Viewport reset to 100% at origin 0,0\./);
       await page.evaluate(() => {
         window.__objectVectorStudioV2App.viewport.zoom = 0.095;
         window.__objectVectorStudioV2App.updateViewport();
       });
-      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas 0,0 centered | Zoom 100%");
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas origin 0,0 centered | Zoom 100%");
       await page.evaluate(() => {
         window.__objectVectorStudioV2App.zoomViewport(2.5);
       });
-      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas 0,0 centered | Zoom 500%");
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas origin 0,0 centered | Zoom 500%");
       await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-320 -220 640 440");
       await page.evaluate(() => {
         window.__objectVectorStudioV2App.zoomViewport(0);
       });
-      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas 0,0 centered | Zoom 10%");
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas origin 0,0 centered | Zoom 10%");
       await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-16000 -11000 32000 22000");
       await page.locator("#objectVectorStudioV2ResetViewButton").click();
       await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-1600 -1100 3200 2200");
@@ -3017,18 +3034,33 @@ test.describe("Workspace Manager V2 bootstrap", () => {
         viewBox: "-640 -440 1280 880"
       });
 
+      const beforePanShapeState = await page.evaluate(() => {
+        const shape = window.__objectVectorStudioV2App.selectedShape();
+        return {
+          geometry: JSON.stringify(shape.geometry),
+          transform: JSON.stringify(shape.transform || null)
+        };
+      });
       await page.locator("#objectVectorStudioV2PanRightButton").click();
       await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-620 -440 1280 880");
-      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 2, 0 | Canvas 0,0 centered | Zoom 250%");
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 2, 0 | Canvas origin -2,0 from center | Zoom 250%");
       await page.locator("#objectVectorStudioV2PanLeftButton").click();
       await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-640 -440 1280 880");
-      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas 0,0 centered | Zoom 250%");
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas origin 0,0 centered | Zoom 250%");
       await page.locator("#objectVectorStudioV2PanUpButton").click();
       await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-640 -460 1280 880");
-      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, -2 | Canvas 0,0 centered | Zoom 250%");
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, -2 | Canvas origin 0,2 from center | Zoom 250%");
       await page.locator("#objectVectorStudioV2PanDownButton").click();
       await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-640 -440 1280 880");
-      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas 0,0 centered | Zoom 250%");
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas origin 0,0 centered | Zoom 250%");
+      const afterPanShapeState = await page.evaluate(() => {
+        const shape = window.__objectVectorStudioV2App.selectedShape();
+        return {
+          geometry: JSON.stringify(shape.geometry),
+          transform: JSON.stringify(shape.transform || null)
+        };
+      });
+      expect(afterPanShapeState).toEqual(beforePanShapeState);
       const examplePointerScreen = await page.locator("#objectVectorStudioV2RenderSurface").evaluate((surface) => {
         const point = surface.createSVGPoint();
         point.x = -140;
@@ -6589,6 +6621,10 @@ test.describe("Workspace Manager V2 bootstrap", () => {
             ship: "object.asteroids.ship"
           }
         };
+        const invalidUnknownGameDataManifest = structuredClone(manifest);
+        invalidUnknownGameDataManifest.game.gameData.debugUnknown = true;
+        const invalidUnknownWorkspaceManifest = structuredClone(manifest.game.workspace);
+        invalidUnknownWorkspaceManifest.debugUnknown = true;
         return {
           gameManifestValidation: await service.validateGameManifest(manifest),
           hasGameData: Boolean(manifest.game?.gameData),
@@ -6598,6 +6634,8 @@ test.describe("Workspace Manager V2 bootstrap", () => {
           runtimeWorkspaceValidation: await service.validateGameManifest(invalidRuntimeWorkspaceManifest),
           rootDocumentKind: manifest.documentKind || "",
           schema: manifest.schema,
+          unknownGameDataValidation: await service.validateGameManifest(invalidUnknownGameDataManifest),
+          unknownWorkspaceValidation: await service.validateGeneratedManifest(invalidUnknownWorkspaceManifest),
           workspaceDocumentKind: manifest.game?.workspace?.documentKind,
           workspaceValidation: await service.validateGeneratedManifest(manifest.game.workspace)
         };
@@ -6610,9 +6648,14 @@ test.describe("Workspace Manager V2 bootstrap", () => {
         objectVectorRuntimeValidation: { ok: false },
         rootDocumentKind: "",
         schema: "html-js-gaming.game-manifest",
+        unknownGameDataValidation: { ok: false },
+        unknownWorkspaceValidation: { ok: false },
         workspaceDocumentKind: "workspace-manifest",
         workspaceValidation: { ok: true }
       });
+      expect(asteroidsGameManifestShape.objectVectorRuntimeValidation.message).toContain("root.game.gameData.objectVectorRuntime is not allowed");
+      expect(asteroidsGameManifestShape.unknownGameDataValidation.message).toContain("root.game.gameData.debugUnknown is not allowed");
+      expect(asteroidsGameManifestShape.unknownWorkspaceValidation.message).toContain("root.debugUnknown is not allowed");
       expect(asteroidsGameManifestShape.runtimeWorkspaceValidation.ok).toBe(false);
       expect(asteroidsGameManifestShape.runtimeWorkspaceValidation.message).toContain("runtime data must not depend on editor/tool workspace state");