Remove duplicate Asteroids object runtime bindings and enforce object IDs as SSoT - PR_26133_044-remove-duplicated-object-vector-runtime-bindings

Author: DavidQ

docs/dev/reports/playwright_v8_coverage_report.md

@@ -1,6 +1,6 @@
-# PR_26133_043 Playwright V8 Coverage Report
+# PR_26133_044 Playwright V8 Coverage Report
 
-Task: PR_26133_043-object-transform-center-and-opacity-input-tuning
+Task: PR_26133_044-remove-duplicated-object-vector-runtime-bindings
 Date: 2026-05-15
 
 ## Result
@@ -10,32 +10,25 @@ PASS - Coverage reporting was generated during `npm run test:workspace-v2`.
 - Coverage source: Playwright/Chromium built-in V8 coverage.
 - Thresholds: none enforced.
 - Coverage is advisory for this PR.
-- Source report: `docs/dev/reports/playwright_v8_coverage_report.txt`.
+- Source report: `docs/dev/reports/playwright_v8_coverage.txt`.
 
 ## Exercised Tool Entry Points
 
 ```text
 (82%) Preview Generator V2 - exercised 19 runtime JS files
 (74%) Asset Manager V2 - exercised 13 runtime JS files
 (62%) Palette Manager V2 - exercised 12 runtime JS files
-(0%) Tool Template V2 - not exercised by this Playwright run
 (91%) Workspace Manager V2 - exercised 10 runtime JS files
-(0%) Workspace Manager - not exercised by this Playwright run
 ```
 
-## Changed Runtime JS Coverage
+## Relevant Runtime Coverage
 
 ```text
-(94%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 4751/4751; executed functions 493/522
+(98%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - executed lines 914/914; executed functions 106/108
+(52%) games/Asteroids/game/AsteroidsGameScene.js - executed lines 846/846; executed functions 25/48
 ```
 
-## Changed Markup/Style/Test Coverage Note
-
-```text
-(0%) tests/playwright/tools/WorkspaceManagerV2.spec.mjs - changed JS file not collected as browser runtime coverage
-```
-
-Markup and CSS changes in `tools/object-vector-studio-v2/index.html` and `tools/object-vector-studio-v2/styles/toolStarter.css` are verified through Playwright DOM/CSS assertions rather than V8 JavaScript coverage.
+The Asteroids runtime role helpers and asteroid geometry helper are exercised through the Asteroids gameplay rendering path and targeted node smoke checks; they are not surfaced as separate changed-runtime rows in the generated V8 summary.
 
 ## Guardrail
 
@@ -45,4 +38,4 @@ Markup and CSS changes in `tools/object-vector-studio-v2/index.html` and `tools/
 
 ## PR-Specific Note
 
-The Workspace V2 run exercised Object Vector Studio V2 Center button labeling and recentering behavior, 0-255 opacity input validation, byte-to-normalized opacity conversion for SVG/schema rendering, and opacity input sizing/layout assertions. Coverage remains advisory only.
+The Workspace V2 run exercised Object Vector runtime manifest loading from `game.workspace.tools.object-vector-studio-v2.objects`, direct object ID role resolution, runtime rendering for asteroids/ship/UFO, and schema rejection of the removed `game.gameData.objectVectorRuntime` branch.

docs/dev/reports/playwright_workspace_v2_results.md

@@ -1,6 +1,6 @@
-# PR_26133_043 Workspace V2 Playwright Results
+# PR_26133_044 Workspace V2 Playwright Results
 
-Task: PR_26133_043-object-transform-center-and-opacity-input-tuning
+Task: PR_26133_044-remove-duplicated-object-vector-runtime-bindings
 Date: 2026-05-15
 
 ## Result
@@ -10,17 +10,22 @@ PASS - `npm run test:workspace-v2` completed successfully.
 - Command: `npm run test:workspace-v2`
 - Playwright target: `tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list`
 - Final result: 51 passed, 0 failed.
-- Runtime/console guard: Object Vector Studio V2 tests that monitor page errors and console errors completed with no reported errors.
+- Runtime/console guard: Asteroids Object Vector runtime and Workspace Manager V2 tests completed with no reported page errors.
 
 ## PR-Specific Coverage
 
-- Verified Object Preview viewport controls now render `Center` instead of `Dot`.
-- Verified Center recenters the preview viewport to origin `0,0`, preserves current zoom, refreshes stale pointer text back to the centered origin display, and keeps the center marker visible.
-- Verified Fill Op and Stroke Op inputs use `min=0`, `max=255`, `step=1`, and width sufficient for 4 visible digits.
-- Verified opacity inputs visibly reject out-of-range values such as `-1` and `256`.
-- Verified valid 0-255 opacity inputs convert to normalized style opacity values for schema/SVG rendering.
-- Verified Fill Op and Stroke Op remain in the compact opacity row below Paint, Stroke, and Width.
+- Verified Asteroids launches Object Vector runtime assets from `game.workspace.tools.object-vector-studio-v2.objects`.
+- Verified runtime role validation resolves `object.asteroids.*` IDs directly from the loaded Object Vector object list.
+- Verified `game.gameData.objectVectorRuntime` is absent from `games/Asteroids/game.manifest.json`.
+- Verified schema validation rejects a manifest when `game.gameData.objectVectorRuntime` is re-added.
+- Verified runtime rendering counts for asteroids, ship, and UFO remain active after removing the duplicate binding map.
 
-## Manual Verification Equivalent
+## Additional Validation
 
-Targeted Object Vector Studio V2 browser automation covered the requested Center label and centering behavior, opacity input sizing/range validation, normalized opacity rendering behavior, Palette opacity row layout, and no-console-error checks.
+- `node` manifest-schema check: current Asteroids manifest returned `{ ok: true }`.
+- `node` manifest-schema check: injected `game.gameData.objectVectorRuntime` returned `{ ok: false }`.
+- Targeted node smoke checks passed for `tests/games/AsteroidsPlatformDemo.test.mjs` and `tests/games/AsteroidsAssetReferenceAdoption.test.mjs`.
+
+## Notes
+
+- `npm test` is blocked before the node suite by the existing shared-extraction guard baseline drift; this PR did not touch those unrelated guard violations.

games/Asteroids/game.manifest.json

@@ -11,16 +11,6 @@
         "directPath": "/games/Asteroids/index.html",
         "workspaceManagerPath": "/tools/workspace-manager-v2/index.html?gameId=Asteroids",
         "workspaceManagerOptional": true
-      },
-      "objectVectorRuntime": {
-        "objectIds": {
-          "ship": "object.asteroids.ship",
-          "asteroidLarge": "object.asteroids.large-asteroid",
-          "asteroidMedium": "object.asteroids.medium-asteroid",
-          "asteroidSmall": "object.asteroids.small-asteroid",
-          "ufoLarge": "object.asteroids.large-ufo",
-          "ufoSmall": "object.asteroids.small-ufo"
-        }
       }
     },
     "workspace": {

games/Asteroids/game/AsteroidsGameScene.js

@@ -17,7 +17,7 @@ import { createAsteroidGeometryProfilesFromObjectVectorAssets } from './asteroid
 import {
   ASTEROID_SIZE_RUNTIME_ROLES,
   runtimeObjectRoleOptions,
-  validateAsteroidsRuntimeObjectBindings
+  validateAsteroidsRuntimeObjectRoles
 } from './asteroidsObjectVectorRoles.js';
 import {
   ASTEROIDS_GAME_OVER_AUTO_EXIT_SECONDS, ASTEROIDS_GAME_OVER_RETURN_MODE
@@ -118,16 +118,15 @@ export default class AsteroidsGameScene extends Scene {
     this.devConsoleIntegration = options.devConsoleIntegration || null;
     this.objectVectorAssets = options.objectVectorAssets || null;
     this.objectVectorRuntime = options.objectVectorRuntime || null;
-    this.objectVectorRuntimeBindings = this.objectVectorAssets?.runtimeBindings || {};
-    this.objectVectorRuntimeBindingValidation = this.objectVectorAssets
-      ? validateAsteroidsRuntimeObjectBindings([...this.objectVectorAssets.objectsById.values()], this.objectVectorRuntimeBindings, {
+    this.objectVectorRuntimeObjectValidation = this.objectVectorAssets
+      ? validateAsteroidsRuntimeObjectRoles([...this.objectVectorAssets.objectsById.values()], {
         logger: this.objectVectorRuntime,
       })
       : { errors: [], objectsByRole: {}, ok: false, warnings: [] };
-    if (this.objectVectorAssets && !this.objectVectorRuntimeBindingValidation.ok) {
-      const message = validationFailureMessage(this.objectVectorRuntimeBindingValidation);
+    if (this.objectVectorAssets && !this.objectVectorRuntimeObjectValidation.ok) {
+      const message = validationFailureMessage(this.objectVectorRuntimeObjectValidation);
       this.objectVectorRuntime?.log?.('FAIL', message, {
-        errors: this.objectVectorRuntimeBindingValidation.errors,
+        errors: this.objectVectorRuntimeObjectValidation.errors,
       });
       console.error(message);
       throw new Error(message);
@@ -869,7 +868,7 @@ export default class AsteroidsGameScene extends Scene {
   }
 
   objectVectorRoleOptions(roleId) {
-    return runtimeObjectRoleOptions(roleId, this.objectVectorRuntimeBindings);
+    return runtimeObjectRoleOptions(roleId);
   }
 
   drawObjectVectorAsset(renderer, renderKey, options) {
@@ -907,7 +906,7 @@ export default class AsteroidsGameScene extends Scene {
         assetCount: this.objectVectorAssets?.objectsById?.size || 0,
         loaded: Boolean(this.objectVectorAssets),
         objectCount: this.objectVectorAssets?.objectsById?.size || 0,
-        runtimeBindingsValid: Boolean(this.objectVectorRuntimeBindingValidation?.ok),
+        runtimeObjectsValid: Boolean(this.objectVectorRuntimeObjectValidation?.ok),
         renderCounts: { ...this.objectVectorRenderCounts },
       };
     } catch {

games/Asteroids/game/asteroidObjectGeometry.js

@@ -9,10 +9,6 @@ const ASTEROID_SIZE_LABELS = Object.freeze({
   3: 'LRG',
 });
 
-function asRecord(value) {
-  return value && typeof value === 'object' && !Array.isArray(value) ? value : {};
-}
-
 function asArray(value) {
   return Array.isArray(value) ? value : [];
 }
@@ -88,15 +84,12 @@ function createProfilesFromObjects(objects, options = {}) {
 }
 
 export function createAsteroidGeometryProfilesFromObjectVectorPayload(payload, options = {}) {
-  return createProfilesFromObjects(asRecord(payload).objects, options);
+  return createProfilesFromObjects(payload?.objects, options);
 }
 
 export function createAsteroidGeometryProfilesFromObjectVectorAssets(assetSet, options = {}) {
   if (assetSet?.objectsById instanceof Map) {
-    return createProfilesFromObjects([...assetSet.objectsById.values()], {
-      runtimeBindings: asRecord(assetSet.runtimeBindings),
-      ...options,
-    });
+    return createProfilesFromObjects([...assetSet.objectsById.values()], options);
   }
   return createAsteroidGeometryProfilesFromObjectVectorPayload(assetSet?.payload, options);
 }

games/Asteroids/game/asteroidsObjectVectorRoles.js

@@ -1,24 +1,30 @@
 export const ASTEROIDS_RUNTIME_OBJECT_ROLES = Object.freeze({
   ship: Object.freeze({
     label: 'Ship',
+    objectId: 'object.asteroids.ship',
   }),
   asteroidLarge: Object.freeze({
     label: 'Large Asteroid',
+    objectId: 'object.asteroids.large-asteroid',
     size: 3,
   }),
   asteroidMedium: Object.freeze({
     label: 'Medium Asteroid',
+    objectId: 'object.asteroids.medium-asteroid',
     size: 2,
   }),
   asteroidSmall: Object.freeze({
     label: 'Small Asteroid',
+    objectId: 'object.asteroids.small-asteroid',
     size: 1,
   }),
   ufoLarge: Object.freeze({
     label: 'Large UFO',
+    objectId: 'object.asteroids.large-ufo',
   }),
   ufoSmall: Object.freeze({
     label: 'Small UFO',
+    objectId: 'object.asteroids.small-ufo',
   }),
 });
 
@@ -36,10 +42,6 @@ function asArray(value) {
   return Array.isArray(value) ? value : [];
 }
 
-function asRecord(value) {
-  return value && typeof value === 'object' && !Array.isArray(value) ? value : {};
-}
-
 function normalizeString(value) {
   return String(value || '').trim();
 }
@@ -73,25 +75,21 @@ function logResolution(logger, level, message, details = {}) {
   logger[method]?.(message, details);
 }
 
-export function runtimeObjectRoleOptions(roleId, runtimeBindings = {}) {
+export function runtimeObjectRoleOptions(roleId) {
   const role = ASTEROIDS_RUNTIME_OBJECT_ROLES[roleId] || null;
   if (!role) {
     return {
       objectId: '',
-      requireManifestBinding: true,
       runtimeRole: roleId,
     };
   }
-  const bindings = asRecord(runtimeBindings);
   return {
-    objectId: normalizeString(bindings[roleId]),
-    requireManifestBinding: true,
+    objectId: normalizeString(role.objectId),
     runtimeRole: roleId,
   };
 }
 
 export function resolveAsteroidsObjectVectorRole(objects, roleId, {
-  runtimeBindings = {},
   logger = null,
 } = {}) {
   const role = ASTEROIDS_RUNTIME_OBJECT_ROLES[roleId] || null;
@@ -101,9 +99,9 @@ export function resolveAsteroidsObjectVectorRole(objects, roleId, {
     return null;
   }
 
-  const explicitObjectId = normalizeString(asRecord(runtimeBindings)[roleId]);
-  const explicitObject = explicitObjectId
-    ? objectList.find((object) => object?.id === explicitObjectId) || null
+  const targetObjectId = normalizeString(role.objectId);
+  const targetObject = targetObjectId
+    ? objectList.find((object) => object?.id === targetObjectId) || null
     : null;
   const candidates = objectList
     .map((object, index) => ({
@@ -113,11 +111,11 @@ export function resolveAsteroidsObjectVectorRole(objects, roleId, {
     }))
     .filter((candidate) => candidate.object);
 
-  if (!explicitObjectId) {
+  if (!targetObjectId) {
     logResolution(
       logger,
       'FAIL',
-      `Asteroids Object Vector runtime role ${roleId} is missing required manifest binding game.gameData.objectVectorRuntime.objectIds.${roleId}.`,
+      `Asteroids Object Vector runtime role ${roleId} is missing its required object ID contract.`,
       {
         candidates: candidates.map(candidateLabel),
         objectCount: objectList.length,
@@ -126,37 +124,37 @@ export function resolveAsteroidsObjectVectorRole(objects, roleId, {
     return null;
   }
 
-  if (!explicitObject) {
+  if (!targetObject) {
     logResolution(
       logger,
       'FAIL',
-      `Asteroids Object Vector runtime role ${roleId} manifest binding ${explicitObjectId} does not match any Object Vector object in game.manifest.json.`,
+      `Asteroids Object Vector runtime role ${roleId} requires object ${targetObjectId} in game.workspace.tools.object-vector-studio-v2.objects.`,
       {
         candidates: candidates.map(candidateLabel),
-        explicitObjectId,
         objectCount: objectList.length,
+        targetObjectId,
       }
     );
     return null;
   }
 
-  if (oldObjectSignal(explicitObject)) {
+  if (oldObjectSignal(targetObject)) {
     logResolution(
       logger,
       'FAIL',
-      `Asteroids Object Vector runtime role ${roleId} manifest binding ${explicitObjectId} points to an old/legacy object; update the manifest binding to the active object.`,
+      `Asteroids Object Vector runtime role ${roleId} object ${targetObjectId} is marked old/legacy; keep runtime object IDs on active Object Vector objects.`,
       {
         candidates: candidates.map(candidateLabel),
-        explicitObjectId,
+        targetObjectId,
       }
     );
     return null;
   }
 
-  return explicitObject;
+  return targetObject;
 }
 
-export function validateAsteroidsRuntimeObjectBindings(objects, runtimeBindings = {}, {
+export function validateAsteroidsRuntimeObjectRoles(objects, {
   logger = null,
 } = {}) {
   const errors = [];
@@ -177,7 +175,6 @@ export function validateAsteroidsRuntimeObjectBindings(objects, runtimeBindings
   ASTEROIDS_REQUIRED_RUNTIME_OBJECT_ROLE_IDS.forEach((roleId) => {
     const object = resolveAsteroidsObjectVectorRole(objects, roleId, {
       logger: collectingLogger,
-      runtimeBindings,
     });
     if (object) {
       objectsByRole[roleId] = object;