Skip to content

Commit b963646

Browse files
author
DavidQ
committed
Simplify Object Vector Studio V2 controls, remove premature type/template/state/library UI, and improve palette/object shape editing - PR_26132_019-object-vector-studio-v2-simplify-controls
1 parent 9f19166 commit b963646

7 files changed

Lines changed: 915 additions & 643 deletions

File tree

docs/dev/reports/playwright_v8_coverage.txt

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,8 @@ Exercised tool entry points detected:
2020
(0%) Workspace Manager - not exercised by this Playwright run
2121

2222
Changed runtime JS files covered:
23-
(80%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 101/101; executed functions 4/5
24-
(91%) tools/object-vector-studio-v2/js/controls/ActionNavControl.js - executed lines 78/78; executed functions 10/11
25-
(91%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 2879/2879; executed functions 334/366
23+
(80%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 92/92; executed functions 4/5
24+
(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 2907/2907; executed functions 318/355
2625

2726
Files with executed line/function counts where available:
2827
(2%) src/engine/input/ActionInputService.js - executed lines 397/397; executed functions 1/51
@@ -168,7 +167,7 @@ Files with executed line/function counts where available:
168167
(80%) src/engine/persistence/StorageService.js - executed lines 49/49; executed functions 4/5
169168
(80%) tools/asset-manager-v2/js/controls/AccordionSection.js - executed lines 27/27; executed functions 4/5
170169
(80%) tools/asset-manager-v2/js/controls/AssetFormControl.js - executed lines 563/563; executed functions 49/61
171-
(80%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 101/101; executed functions 4/5
170+
(80%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 92/92; executed functions 4/5
172171
(80%) tools/palette-manager-v2/modules/PaletteHistoryStack.js - executed lines 54/54; executed functions 8/10
173172
(80%) tools/preview-generator-v2/controls/AccordionSection.js - executed lines 31/31; executed functions 4/5
174173
(80%) tools/preview-generator-v2/PreviewGeneratorV2Logger.js - executed lines 19/19; executed functions 4/5
@@ -194,11 +193,11 @@ Files with executed line/function counts where available:
194193
(88%) tools/world-vector-studio-v2/js/controls/SourceInputControl.js - executed lines 33/33; executed functions 7/8
195194
(89%) tools/asset-manager-v2/js/services/AssetSchemaValidator.js - executed lines 295/295; executed functions 25/28
196195
(89%) tools/preview-generator-v2/controls/StatusLogControl.js - executed lines 32/32; executed functions 8/9
196+
(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 2907/2907; executed functions 318/355
197197
(90%) tools/palette-manager-v2/modules/PaletteValidationService.js - executed lines 88/88; executed functions 9/10
198198
(90%) tools/text2speech-V2/js/controls/ActionNavControl.js - executed lines 117/117; executed functions 19/21
199199
(90%) tools/text2speech-V2/js/TextToSpeechToolApp.js - executed lines 807/807; executed functions 62/69
200200
(91%) tools/object-vector-studio-v2/js/controls/ActionNavControl.js - executed lines 78/78; executed functions 10/11
201-
(91%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 2879/2879; executed functions 334/366
202201
(91%) tools/toolRegistry.js - executed lines 526/526; executed functions 10/11
203202
(91%) tools/workspace-manager-v2/js/services/WorkspaceManagerV2ContextService.js - executed lines 1598/1598; executed functions 145/159
204203
(92%) tools/object-vector-studio-v2/js/controls/ToolStarterShellControl.js - executed lines 112/112; executed functions 11/12
@@ -296,5 +295,4 @@ Changed JS files considered:
296295
(0%) tests/playwright/tools/WorkspaceManagerV2.spec.mjs - changed JS file not collected as browser runtime coverage
297296
(0%) tools/object-vector-studio-v2/tests/playwright/FirstClassToolStarter.spec.mjs - changed JS file not collected as browser runtime coverage
298297
(80%) tools/object-vector-studio-v2/js/bootstrap.js - changed JS file with browser V8 coverage
299-
(91%) tools/object-vector-studio-v2/js/controls/ActionNavControl.js - changed JS file with browser V8 coverage
300-
(91%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed JS file with browser V8 coverage
298+
(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed JS file with browser V8 coverage
Lines changed: 80 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,80 @@
1+
# PR_26132_019-object-vector-studio-v2-simplify-controls
2+
3+
## Scope
4+
5+
Updates Object Vector Studio V2 UI/control behavior only. No schema changes, no sample JSON changes, no World Vector Studio V2 runtime changes.
6+
7+
## Changes
8+
9+
- Simplified Shape/Tools so Words/Icons affects only shape buttons; reset, viewport, grid, snap, frame, and runtime buttons remain text-only.
10+
- Replaced shape initials with visual icons for select, triangle, rectangle, circle, ellipse, line, polygon, arc, and text.
11+
- Added a separator between shape tools and grid/snap controls, kept shape buttons square, and let the grid fit as many buttons across as available.
12+
- Removed hardcoded category/tag controls and replaced them with editable object tags plus a dynamic tag filter.
13+
- Removed Object Type, Template, active state UI, and active library asset UI from the current editing surface; deferred notes are logged/status-documented.
14+
- Reworked Palette controls: removed Current Color, added hue/sat/bri/name sort buttons, kept square swatches, and exposed stacked hover details.
15+
- Removed duplicate SVG grid rendering; the remaining CSS grid is toggled by the Grid button.
16+
- Moved Object Preview actions under the canvas and placed the selected object id in the center-column footer.
17+
- Added selected-object shape rows under the active object tile, with selected object/shape highlighting.
18+
- Added runtime-only object eye/lock controls and shape eye controls; object lock blocks mutating edits.
19+
- Started JSON Details, Dependency Graph, and Status Log collapsed in the right column.
20+
- Moved Object Details action buttons under the canvas and kept Object Details focused on selected-shape editable fields.
21+
22+
## Validation
23+
24+
Playwright impacted: Yes.
25+
26+
Commands run:
27+
28+
- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=line -g "Object Vector Studio V2 layout shell|expands Object Vector Studio V2 asset authoring|animation states" --timeout=120000`
29+
- `npm run test:workspace-v2`
30+
31+
Result:
32+
33+
- Targeted Object Vector Studio V2 checks passed: 3 passed.
34+
- Full Workspace Manager V2 suite passed: 45 passed.
35+
- Playwright V8 coverage refreshed at `docs/dev/reports/playwright_v8_coverage.txt`.
36+
- Full samples smoke test skipped per request; this PR is limited to Object Vector Studio V2 UI/control behavior and workspace-v2 coverage validates the impacted surface.
37+
38+
## Playwright Coverage
39+
40+
Validates:
41+
42+
- Words/Icons affects only Shape/Tools buttons.
43+
- Real shape icons render.
44+
- Object/shape selection rows highlight correctly.
45+
- Object and shape visibility controls work.
46+
- Object lock blocks edits.
47+
- Duplicate SVG grid rendering is absent and the Grid button toggles the remaining grid.
48+
- Palette sorting controls render.
49+
- Right-column JSON Details, Dependency Graph, and Status Log start collapsed.
50+
- Object Type and Template UI are removed.
51+
52+
Expected pass behavior:
53+
54+
- Simplified controls render in the requested layout, object/tag filtering works without hardcoded category lists, and runtime-only object visibility/lock state updates without changing schema payloads.
55+
56+
Expected fail behavior:
57+
58+
- Missing payloads, invalid payloads, missing palette, locked objects, or missing selections log visible/actionable WARN/FAIL entries and do not silently mutate or render invalid state.
59+
60+
## Manual Validation
61+
62+
1. Open `tools/object-vector-studio-v2/index.html`.
63+
2. Load a valid Object Vector payload with a runtime palette.
64+
3. Confirm Shape/Tools shows visual icons, square buttons, and Words/Icons only changes those buttons.
65+
4. Add/edit object tags and confirm Tag Filter options come from loaded object tags.
66+
5. Toggle object eye/lock controls and confirm hidden objects stop rendering and locked objects block edits.
67+
6. Toggle Grid and confirm the single visible grid appears/disappears.
68+
7. Confirm JSON Details, Dependency Graph, and Status Log start collapsed.
69+
70+
Expected outcome:
71+
72+
- Object Vector Studio V2 presents a cleaner control surface with no Object Type/Template UI, dynamic tags, working object/shape visibility, runtime object locking, and no duplicate grid rendering.
73+
74+
## Out Of Scope
75+
76+
- No schema changes.
77+
- No sample JSON changes.
78+
- No new major feature systems.
79+
- No World Vector Studio V2 runtime mutation changes.
80+
- No full samples smoke test.

0 commit comments

Comments
 (0)